OSError preadv()

[YoSTEALTH]

BPO	37509
Nosy	@vstinner, @YoSTEALTH, @pablogsal

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-12-25.15:43:58.290>
created_at = <Date 2019-07-05.17:50:39.691>
labels = ['invalid', 'type-bug', '3.8']
title = 'OSError preadv()'
updated_at = <Date 2019-12-25.15:43:58.290>
user = 'https://github.com/YoSTEALTH'

bugs.python.org fields:

activity = <Date 2019-12-25.15:43:58.290>
actor = 'YoSTEALTH'
assignee = 'none'
closed = True
closed_date = <Date 2019-12-25.15:43:58.290>
closer = 'YoSTEALTH'
components = []
creation = <Date 2019-07-05.17:50:39.691>
creator = 'YoSTEALTH'
dependencies = []
files = []
hgrepos = []
issue_num = 37509
keywords = []
message_count = 2.0
messages = ['347364', '358869']
nosy_count = 3.0
nosy_names = ['vstinner', 'YoSTEALTH', 'pablogsal']
pr_nums = []
priority = 'normal'
resolution = 'not a bug'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue37509'
versions = ['Python 3.8']

[YoSTEALTH]

import os
import ctypes

# Stdlib
# ------

def test_preadv_stdlib(path):
    fd = os.open(path, os.O_RDWR | os.O_CREAT)
    buffer = bytearray(10)
    buffers = [buffer]
    try:
        length = os.preadv(fd, buffers, 0, os.RWF_NOWAIT)
        # OSError: [Errno 95] Operation not supported
        print('length:', length)
        print('buffer:', buffer)
    finally:
        os.close(fd)

# Cyptes Libc
# -----------

class iovec(ctypes.Structure):
    _fields_ = [('iov_base', ctypes.c_char_p), ('iov_len', ctypes.c_size_t)]


libc = ctypes.CDLL('libc.so.6')


def test_preadv_libc(path):
    fd = os.open(path, os.O_RDWR | os.O_CREAT)
    buffer = bytes(10)
    buffers = (iovec*1)()
    buffers[0].iov_base = buffer
    buffers[0].iov_len = 10
    try:
        length = libc.preadv2(fd, buffers, len(buffers), 0, os.RWF_NOWAIT)
        print('length:', length)  # length: -1
        print('buffer:', buffer)  # buffer: b'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00'
    finally:
        os.close(fd)

# Test Run
# --------

def test():
    path = '/dev/shm/test-preadv-in-ram-file'

# Test-1 stdlib implementation
try:
    test_preadv_stdlib(path)  # OSError: [Errno 95] Operation not supported
except OSError:
    print('OSError is raised. This should not raise OSError')

    # Test-2 custom ctype `libc` implementation
    test_preadv_libc(path)


if __name__ == '__main__':
    test()

This code is just to demonstrate working vs receiving an OSError in this specific usage.

System: Linux 4.19.56-1-MANJARO
Python: 3.8.0b2

When the file in question is stored in ram ('/dev/shm') stdlib implementation raises an OSError while libc version does not.

[YoSTEALTH]

I am closing this topic as its right for python to raise OSError as -errno must be assigned to e.g. OSError(-errno, os.strerror(-errno)) to raise appropriate exception.