hashopenssl fails to compile on MacOS

[pablogsal]

BPO	38137
Nosy	@ronaldoussoren, @tiran, @ned-deily, @pablogsal, @miss-islington
PRs	bpo-38137: Re-add OpenSSL 1.0.2 compat #16051 [3.8] bpo-38137: Re-add OpenSSL 1.0.2 compat (GH-16051) #16057

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-12-12.13:52:09.813>
created_at = <Date 2019-09-12.13:36:09.614>
labels = ['OS-mac', 'build', '3.9']
title = 'hashopenssl fails to compile on MacOS'
updated_at = <Date 2020-12-12.13:52:09.813>
user = 'https://github.com/pablogsal'

bugs.python.org fields:

activity = <Date 2020-12-12.13:52:09.813>
actor = 'christian.heimes'
assignee = 'none'
closed = True
closed_date = <Date 2020-12-12.13:52:09.813>
closer = 'christian.heimes'
components = ['Build', 'macOS']
creation = <Date 2019-09-12.13:36:09.614>
creator = 'pablogsal'
dependencies = []
files = []
hgrepos = []
issue_num = 38137
keywords = ['patch']
message_count = 5.0
messages = ['352161', '352177', '352191', '382909', '382912']
nosy_count = 5.0
nosy_names = ['ronaldoussoren', 'christian.heimes', 'ned.deily', 'pablogsal', 'miss-islington']
pr_nums = ['16051', '16057']
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue38137'
versions = ['Python 3.9']

[pablogsal]

I get this when compiling CPython master

Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:89:19: error: implicit declaration of function 'EVP_MD_CTX_new' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
retval->ctx = EVP_MD_CTX_new();
^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:89:19: warning: this function declaration is not a prototype [-Wstrict-prototypes]
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:89:17: warning: incompatible integer to pointer conversion assigning to 'EVP_MD_CTX *' (aka 'struct env_md_ctx_st *') from 'int' [-Wint-conversion]
retval->ctx = EVP_MD_CTX_new();
^ ~~~~~~~~~~~~~~~~
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:126:5: error: implicit declaration of function 'EVP_MD_CTX_free' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
EVP_MD_CTX_free(self->ctx);
^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:126:5: note: did you mean 'EVP_MD_CTX_create'?
/usr/local/opt/openssl/include/openssl/evp.h:588:13: note: 'EVP_MD_CTX_create' declared here
EVP_MD_CTX *EVP_MD_CTX_create(void);
^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:126:5: warning: this function declaration is not a prototype [-Wstrict-prototypes]
EVP_MD_CTX_free(self->ctx);
^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:179:16: error: implicit declaration of function 'EVP_MD_CTX_new' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
temp_ctx = EVP_MD_CTX_new();
^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:179:14: warning: incompatible integer to pointer conversion assigning to 'EVP_MD_CTX *' (aka 'struct env_md_ctx_st *') from 'int' [-Wint-conversion]
temp_ctx = EVP_MD_CTX_new();
^ ~~~~~~~~~~~~~~~~
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:195:5: error: implicit declaration of function 'EVP_MD_CTX_free' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
EVP_MD_CTX_free(temp_ctx);
^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:213:16: error: implicit declaration of function 'EVP_MD_CTX_new' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
temp_ctx = EVP_MD_CTX_new();
^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:213:14: warning: incompatible integer to pointer conversion assigning to 'EVP_MD_CTX *' (aka 'struct env_md_ctx_st *') from 'int' [-Wint-conversion]
temp_ctx = EVP_MD_CTX_new();
^ ~~~~~~~~~~~~~~~~
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:229:5: error: implicit declaration of function 'EVP_MD_CTX_free' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
EVP_MD_CTX_free(temp_ctx);

❯ openssl version
LibreSSL 2.6.5

[miss-islington]

New changeset 9a4963b by Miss Islington (bot) (Christian Heimes) in branch 'master':
bpo-38137: Re-add OpenSSL 1.0.2 compat (GH-16051)
9a4963b

[miss-islington]

New changeset 36c29e4 by Miss Islington (bot) (Stéphane Wirtel) in branch '3.8':
[3.8] bpo-38137: Re-add OpenSSL 1.0.2 compat (GH-16051) (GH-16057)
36c29e4

[ronaldoussoren]

can this issue be closed?

[tiran]

I don't have access to macOS. Did the PR fix the issue?