test__xxsubinterpreters: random failures on AMD64 FreeBSD CURRENT Shared 3.x

[vstinner]

BPO	38154
Nosy	@vstinner, @ericsnowcurrently, @nanjekyejoannah, @aeros
PRs	bpo-37224: Fix test__xxsubinterpreters failure and GIL handling in interp_destroy() #16293
Superseder	bpo-37224: [subinterpreters] test__xxsubinterpreters fails randomly

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-10-14.21:26:24.628>
created_at = <Date 2019-09-13.09:50:39.966>
labels = ['tests', '3.9']
title = 'test__xxsubinterpreters: random failures on AMD64 FreeBSD CURRENT Shared 3.x'
updated_at = <Date 2019-10-14.21:26:24.617>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2019-10-14.21:26:24.617>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2019-10-14.21:26:24.628>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2019-09-13.09:50:39.966>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 38154
keywords = ['patch']
message_count = 5.0
messages = ['352271', '352520', '352841', '353546', '354660']
nosy_count = 4.0
nosy_names = ['vstinner', 'eric.snow', 'nanjekyejoannah', 'aeros']
pr_nums = ['16293']
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '37224'
type = None
url = 'https://bugs.python.org/issue38154'
versions = ['Python 3.9']

[vstinner]

It seems like test__xxsubinterpreters still has race conditions.

See also bpo-37224 and bpo-33356.

AMD64 FreeBSD CURRENT Shared 3.x:
https://buildbot.python.org/all/#/builders/168/builds/1428

FAIL: test_subinterpreter (test.test__xxsubinterpreters.IsRunningTests)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/test/test__xxsubinterpreters.py", line 492, in test_subinterpreter
    self.assertTrue(interpreters.is_running(interp))
AssertionError: False is not true

Later, when test__xxsubinterpreters is re-run in verbose mode:

FAIL: test_still_running (test.test__xxsubinterpreters.DestroyTests)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/test/test__xxsubinterpreters.py", line 765, in test_still_running
    interpreters.destroy(interp)
AssertionError: RuntimeError not raised

[aeros]

I believe I found a potential fix, see https://bugs.python.org/issue37224?@ok_message=msg%20352516%20created%0Aissue%2037224%20message_count%2C%20messages%20edited%20ok&@template=item#msg352514. Should I attach the PR to that issue or this one?

[aeros]

For an updated explanation of the PR, see https://bugs.python.org/msg352835 or the comments in the PR itself.

[vstinner]

https://buildbot.python.org/all/#/builders/286/builds/27

FAIL: test_subinterpreter (test.test__xxsubinterpreters.IsRunningTests)

[vstinner]

I close this issue as a duplicate of bpo-37224.