Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuspec iconUrl field is deprecated #82584

Closed
zooba opened this issue Oct 8, 2019 · 4 comments
Closed

nuspec iconUrl field is deprecated #82584

zooba opened this issue Oct 8, 2019 · 4 comments
Assignees
Labels
3.8 only security fixes 3.9 only security fixes OS-windows type-bug An unexpected behavior, bug, or error

Comments

@zooba
Copy link
Member

zooba commented Oct 8, 2019

BPO 38403
Nosy @pfmoore, @tjguk, @zware, @zooba, @miss-islington
PRs
  • bpo-38403: Update nuspec file for deprecated field and git repository #18657
  • [3.8] bpo-38403: Update nuspec file for deprecated field and git repository (GH-18657) #18660
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
    closed_at = <Date 2020-02-25.20:55:34.914>
    created_at = <Date 2019-10-08.04:21:41.490>
    labels = ['type-bug', '3.8', '3.9', 'OS-windows']
    title = 'nuspec iconUrl field is deprecated'
    updated_at = <Date 2020-02-25.20:55:34.913>
    user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2020-02-25.20:55:34.913>
    actor = 'steve.dower'
    assignee = 'steve.dower'
    closed = True
    closed_date = <Date 2020-02-25.20:55:34.914>
    closer = 'steve.dower'
    components = ['Windows']
    creation = <Date 2019-10-08.04:21:41.490>
    creator = 'steve.dower'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 38403
    keywords = ['patch']
    message_count = 4.0
    messages = ['354167', '362661', '362664', '362667']
    nosy_count = 5.0
    nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'miss-islington']
    pr_nums = ['18657', '18660']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue38403'
    versions = ['Python 3.8', 'Python 3.9']

    @zooba
    Copy link
    Member Author

    zooba commented Oct 8, 2019

    The iconUrl field has to be replaced with an icon field, and we need to include the file in the package now.

    Details at https://docs.microsoft.com/en-us/nuget/reference/nuspec#icon

    @zooba zooba added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Oct 8, 2019
    @zooba zooba self-assigned this Oct 8, 2019
    @zooba zooba added OS-windows type-bug An unexpected behavior, bug, or error labels Oct 8, 2019
    @zooba
    Copy link
    Member Author

    zooba commented Feb 25, 2020

    New changeset d644891 by Steve Dower in branch 'master':
    bpo-38403: Update nuspec file for deprecated field and git repository (GH-18657)
    d644891

    @miss-islington
    Copy link
    Contributor

    New changeset 1bbb81b by Miss Islington (bot) in branch '3.8':
    bpo-38403: Update nuspec file for deprecated field and git repository (GH-18657)
    1bbb81b

    @zooba
    Copy link
    Member Author

    zooba commented Feb 25, 2020

    Not enough value fixing 3.7 and 2.7 at this stage - nuget.org can't actively *break* the old format without spoiling half the repository, so I'm sure it'll be fine to leave them as they are for the last few uploads.

    @zooba zooba removed the 3.7 (EOL) end of life label Feb 25, 2020
    @zooba zooba closed this as completed Feb 25, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes 3.9 only security fixes OS-windows type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants