Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py_USING_MEMORY_DEBUGGER is referenced in docs but not present in code #82703

Closed
SmerCip mannequin opened this issue Oct 18, 2019 · 4 comments
Closed

Py_USING_MEMORY_DEBUGGER is referenced in docs but not present in code #82703

SmerCip mannequin opened this issue Oct 18, 2019 · 4 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes build The build process and cross-build easy

Comments

@SmerCip
Copy link
Mannequin

SmerCip mannequin commented Oct 18, 2019

BPO 38522
Nosy @benjaminp, @miss-islington, @isidentical, @carlosdamazio, @carlosdamazio
PRs
  • bpo-38522: remove references to excluded Py_USING_MEMORY_DEBUGGER #30284
  • [3.10] closes bpo-38522 docs: remove references to Py_USING_MEMORY_DEBUGGER (GH-30284) #30295
  • [3.9] closes bpo-38522 docs: remove references to Py_USING_MEMORY_DEBUGGER (GH-30284) #30296
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-12-29.23:01:25.937>
    created_at = <Date 2019-10-18.22:01:11.915>
    labels = ['easy', 'build', '3.9', '3.10', '3.11']
    title = 'Py_USING_MEMORY_DEBUGGER is referenced in docs but not present in code'
    updated_at = <Date 2021-12-29.23:01:25.937>
    user = 'https://bugs.python.org/SmerCip'

    bugs.python.org fields:

    activity = <Date 2021-12-29.23:01:25.937>
    actor = 'benjamin.peterson'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-12-29.23:01:25.937>
    closer = 'benjamin.peterson'
    components = ['Build']
    creation = <Date 2019-10-18.22:01:11.915>
    creator = 'S\xc3\xbcmer.Cip'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 38522
    keywords = ['patch', 'easy']
    message_count = 4.0
    messages = ['354922', '355010', '409327', '409333']
    nosy_count = 6.0
    nosy_names = ['benjamin.peterson', 'S\xc3\xbcmer.Cip', 'miss-islington', 'BTaskaya', 'dmzz', 'carlosdamazio']
    pr_nums = ['30284', '30295', '30296']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue38522'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    @SmerCip
    Copy link
    Mannequin Author

    SmerCip mannequin commented Oct 18, 2019

    Hi all,

    While trying to debug Python C extension via valgrind, I was reading the document Misc/README.valgrind and it seems there are some parts not being uptodate. There is comments comments like following:

    Uncomment Py_USING_MEMORY_DEBUGGER in Objects/obmalloc.c, then rebuild Python. This define seems to be removed from the obmalloc.c file and also I am not sure if anything is using it at all. When I searched the code, only Python/dtoa.c have a reference to this define. Anyway, I have not specifically investigated the reason behind of the removal of the define but it seems it is removed somewhere between 3.3 and 3.4. I am assuming it might be related with tracemalloc maybe?

    Cheers,

    @SmerCip SmerCip mannequin added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes build The build process and cross-build labels Oct 18, 2019
    @isidentical
    Copy link
    Sponsor Member

    It looks like benjamin peterson removed remaining references from obmalloc.c in 3924f93

    @iritkatriel iritkatriel added easy 3.10 only security fixes 3.11 only security fixes and removed 3.7 (EOL) end of life 3.8 only security fixes labels Dec 6, 2021
    @carlosdamazio
    Copy link
    Mannequin

    carlosdamazio mannequin commented Dec 29, 2021

    Opened a PR for this issue. It'll remove the mentions to the Py_USING_MEMORY_DEBUGGER since it'd been removed 5 years ago.

    @benjaminp
    Copy link
    Contributor

    New changeset 9f0e40f by Miss Islington (bot) in branch '3.10':
    closes bpo-38522 docs: remove references to Py_USING_MEMORY_DEBUGGER (GH-30284) (GH-30295)
    9f0e40f

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes build The build process and cross-build easy
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants