Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyncio cannot handle Python3 IPv4Address #83133

Closed
vegerot mannequin opened this issue Dec 2, 2019 · 5 comments
Closed

asyncio cannot handle Python3 IPv4Address #83133

vegerot mannequin opened this issue Dec 2, 2019 · 5 comments
Labels
3.9 only security fixes topic-asyncio type-feature A feature request or enhancement

Comments

@vegerot
Copy link
Mannequin

vegerot mannequin commented Dec 2, 2019

BPO 38952
Nosy @terryjreedy, @asvetlov, @1st1, @tirkarthi, @vegerot
PRs
  • gh-79200: support IPAddress in asyncio.start_server() #17434
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2019-12-02.01:07:46.574>
    labels = ['type-feature', '3.9', 'expert-asyncio']
    title = 'asyncio cannot handle Python3 IPv4Address'
    updated_at = <Date 2019-12-06.22:09:09.728>
    user = 'https://github.com/vegerot'

    bugs.python.org fields:

    activity = <Date 2019-12-06.22:09:09.728>
    actor = 'terry.reedy'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['asyncio']
    creation = <Date 2019-12-02.01:07:46.574>
    creator = 'Max Coplan'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 38952
    keywords = ['patch']
    message_count = 4.0
    messages = ['357697', '357703', '357714', '357948']
    nosy_count = 5.0
    nosy_names = ['terry.reedy', 'asvetlov', 'yselivanov', 'xtreak', 'Max Coplan']
    pr_nums = ['17434']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue38952'
    versions = ['Python 3.9']

    @vegerot
    Copy link
    Mannequin Author

    vegerot mannequin commented Dec 2, 2019

    Trying to use new Python 3 IPv4Addresss fails with the following error

    File "/usr/local/Cellar/python/3.7.5/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/base_events.py", line 1270, in _ensure_resolved
        info = _ipaddr_info(host, port, family, type, proto, *address[2:])
      File "/usr/local/Cellar/python/3.7.5/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/base_events.py", line 134, in _ipaddr_info
        if '%' in host:
    TypeError: argument of type 'IPv4Address' is not iterable
    

    @vegerot vegerot mannequin added 3.7 (EOL) end of life 3.8 only security fixes topic-asyncio labels Dec 2, 2019
    @vegerot vegerot mannequin changed the title asyncio cannot handle Python3 IPv4Address or IPv6 Address asyncio cannot handle Python3 IPv4Address Dec 2, 2019
    @tirkarthi
    Copy link
    Member

    This looks like a duplicate of bpo-35019.

    @tirkarthi tirkarthi added 3.9 only security fixes type-feature A feature request or enhancement and removed 3.7 (EOL) end of life 3.8 only security fixes labels Dec 2, 2019
    @vegerot
    Copy link
    Mannequin Author

    vegerot mannequin commented Dec 2, 2019

    Well I’ve submitted a fix for it. It isn’t perfect. Well, while it doesn’t look perfect, it actually worked with everything I’ve thrown at it, and seems to be a very robust and sufficient fix.

    @terryjreedy
    Copy link
    Member

    If this is a duplicate of bpo-35019, then this issue should be closed, the original post here should be copied over, and the PR should be edited to point to the original issue, both in the title and the box below the title.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @kumaraditya303
    Copy link
    Contributor

    Duplicate of #79200

    @kumaraditya303 kumaraditya303 marked this as a duplicate of #79200 Sep 29, 2022
    @kumaraditya303 kumaraditya303 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes topic-asyncio type-feature A feature request or enhancement
    Projects
    Status: Done
    Development

    No branches or pull requests

    3 participants