Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_largefile: TestSocketSendfile.test_it() failed on AMD64 Fedora Stable Refleaks 3.x #83185

Closed
vstinner opened this issue Dec 9, 2019 · 5 comments
Labels
3.9 only security fixes tests Tests in the Lib/test dir

Comments

@vstinner
Copy link
Member

vstinner commented Dec 9, 2019

BPO 39004
Nosy @vstinner, @giampaolo, @pablogsal
PRs
  • bpo-39004: increment large sendfile() test timeout #17552
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-12-10.12:29:56.485>
    created_at = <Date 2019-12-09.13:24:37.405>
    labels = ['tests', '3.9']
    title = 'test_largefile: TestSocketSendfile.test_it() failed on AMD64 Fedora Stable Refleaks 3.x'
    updated_at = <Date 2019-12-10.12:29:56.480>
    user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2019-12-10.12:29:56.480>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-12-10.12:29:56.485>
    closer = 'vstinner'
    components = ['Tests']
    creation = <Date 2019-12-09.13:24:37.405>
    creator = 'vstinner'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 39004
    keywords = ['patch']
    message_count = 5.0
    messages = ['358075', '358076', '358172', '358174', '358184']
    nosy_count = 3.0
    nosy_names = ['vstinner', 'giampaolo.rodola', 'pablogsal']
    pr_nums = ['17552']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue39004'
    versions = ['Python 3.9']

    @vstinner
    Copy link
    Member Author

    vstinner commented Dec 9, 2019

    0:22:15 load avg: 15.82 [288/420/3] test_largefile failed (11 min 19 sec) -- running: test_capi (2 min 40 sec), test_compileall (3 min 42 sec), test_shelve (14 min 46 sec), test_sax (10 min 4 sec), test_dbm (3 min 36 sec), test_multiprocessing_spawn (13 min 21 sec), test_posix (3 min 39 sec), test_mailbox (12 min 46 sec), test_asyncio (9 min 23 sec)
    beginning 6 repetitions
    123456
    .Warning -- threading._dangling was modified by test_largefile
      Before: {<weakref at 0x7f1cf0e08fb0; to '_MainThread' at 0x7f1cf19395a0>}
      After:  {<weakref at 0x7f1cf0526470; to '_MainThread' at 0x7f1cf19395a0>, <weakref at 0x7f1cf0526170; to 'Thread' at 0x7f1cf057a3c0>} 
    test test_largefile failed -- Traceback (most recent call last):
      File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/test_largefile.py", line 211, in test_it
        self.assertEqual(os.path.getsize(TESTFN2), size)
    AssertionError: 2496925696 != 2500000001

    @vstinner
    Copy link
    Member Author

    vstinner commented Dec 9, 2019

    AMD64 Fedora Stable Refleaks 3.x:
    https://buildbot.python.org/all/#/builders/126/builds/14

    @vstinner vstinner added 3.9 only security fixes tests Tests in the Lib/test dir labels Dec 9, 2019
    @vstinner vstinner changed the title test_largefile: test_it() failed on test_largefile: TestSocketSendfile.test_it() failed on AMD64 Fedora Stable Refleaks 3.x Dec 9, 2019
    @giampaolo
    Copy link
    Contributor

    I suspect it's a timing problem (client disconnects, threaded server fails to detect that in time). Let's see what happens by incrementing the timeout when waiting for the thread to be join()ed (PR-17552).

    @giampaolo
    Copy link
    Contributor

    New changeset 8237497 by Giampaolo Rodola in branch 'master':
    bpo-39004: increment large sendfile() test timeout (GH-17552)
    8237497

    @vstinner
    Copy link
    Member Author

    Let's say that it's enough to hide the race condition :-) I close the issue.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes tests Tests in the Lib/test dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants