The header files in Include/ have many declarations with no definition

[pablogsal]

BPO	39372
Nosy	@vstinner, @encukou, @serhiy-storchaka, @ZackerySpytz, @pablogsal
PRs	bpo-39372: Clean header files of declared interfaces with no implementations #18037

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2020-01-17.17:47:13.671>
labels = ['type-feature', '3.9', 'build']
title = 'The header files in Include/ have many declarations with no definition'
updated_at = <Date 2020-06-09.16:44:46.269>
user = 'https://github.com/pablogsal'

bugs.python.org fields:

activity = <Date 2020-06-09.16:44:46.269>
actor = 'vstinner'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Build']
creation = <Date 2020-01-17.17:47:13.671>
creator = 'pablogsal'
dependencies = []
files = []
hgrepos = []
issue_num = 39372
keywords = ['patch']
message_count = 8.0
messages = ['360204', '360207', '360229', '360238', '360240', '360246', '371083', '371125']
nosy_count = 5.0
nosy_names = ['vstinner', 'petr.viktorin', 'serhiy.storchaka', 'ZackerySpytz', 'pablogsal']
pr_nums = ['18037']
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue39372'
versions = ['Python 3.9']

[pablogsal]

There are many declarations that lack definitions in our header files that should be cleaned (linking against those symbols will fail so removing them should be safe if I am not missing something).

[serhiy-storchaka]

Good catch!

All removals LGTM.

[pablogsal]

New changeset cd7db76 by Pablo Galindo in branch 'master':
bpo-39372: Clean header files of declared interfaces with no implementations (GH-18037)
cd7db76

[ZackerySpytz]

The removal of PyNoArgsFunction is the subject of bpo-18091.

[serhiy-storchaka]

Maybe backport this change (except PyNoArgsFunction)?

[pablogsal]

Maybe backport this change (except PyNoArgsFunction)?

I didn't think of backporting to reduce the possibilities of something going wrong, but is true that a backport without PyNoArgsFunction should be harmless.

Reopening the issue meanwhile I do on the backports.

[encukou]

Since the removal of PyNoArgsFunction breaks user code, does it deserve a mention in What's New – Porting to Python 3.9?

[vstinner]

Maybe backport this change (except PyNoArgsFunction)?

I don't think that it's a good idea. I suggest to only do cleanup in the master branch, just in case if something goes wrong. Like the PyNoArgsFunction removal :-)