Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyncio.Task.all_tasks() and asyncio.Task.current_task() must be removed in 3.9 #85139

Closed
remilapeyre mannequin opened this issue Jun 13, 2020 · 9 comments
Closed

asyncio.Task.all_tasks() and asyncio.Task.current_task() must be removed in 3.9 #85139

remilapeyre mannequin opened this issue Jun 13, 2020 · 9 comments
Labels
3.9 only security fixes 3.10 only security fixes topic-asyncio

Comments

@remilapeyre
Copy link
Mannequin

remilapeyre mannequin commented Jun 13, 2020

BPO 40967
Nosy @asvetlov, @ambv, @1st1, @miss-islington, @remilapeyre, @aeros
PRs
  • bpo-40967: Remove deprecated asyncio.Task.current_task() and asyncio.Task.all_tasks() #20874
  • [3.9] bpo-40967: Remove deprecated asyncio.Task.current_task() and asyncio.Task.all_tasks() (GH-20874) #21272
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2022-03-12.19:21:04.024>
    created_at = <Date 2020-06-13.10:48:02.052>
    labels = ['3.9', '3.10', 'expert-asyncio']
    title = 'asyncio.Task.all_tasks() and asyncio.Task.current_task() must be removed in 3.9'
    updated_at = <Date 2022-03-12.19:21:04.023>
    user = 'https://github.com/remilapeyre'

    bugs.python.org fields:

    activity = <Date 2022-03-12.19:21:04.023>
    actor = 'asvetlov'
    assignee = 'none'
    closed = True
    closed_date = <Date 2022-03-12.19:21:04.024>
    closer = 'asvetlov'
    components = ['asyncio']
    creation = <Date 2020-06-13.10:48:02.052>
    creator = 'remi.lapeyre'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 40967
    keywords = ['patch']
    message_count = 9.0
    messages = ['371449', '371451', '372475', '372483', '372628', '372630', '372800', '372801', '372802']
    nosy_count = 6.0
    nosy_names = ['asvetlov', 'lukasz.langa', 'yselivanov', 'miss-islington', 'remi.lapeyre', 'aeros']
    pr_nums = ['20874', '21272']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue40967'
    versions = ['Python 3.9', 'Python 3.10']

    @remilapeyre
    Copy link
    Mannequin Author

    remilapeyre mannequin commented Jun 13, 2020

    The documentation says:

      .. deprecated-removed:: 3.7 3.9
    
         Do not call this as a task method. Use the :func:`asyncio.all_tasks`
         function instead.
    

    I don't know if it's still possible to merge this in 3.9 and if so, if it should be a release blocker. Anyway I'm working on a PR for this.

    @remilapeyre remilapeyre mannequin added 3.9 only security fixes 3.10 only security fixes topic-asyncio labels Jun 13, 2020
    @aeros
    Copy link
    Contributor

    aeros commented Jun 13, 2020

    Thanks for bringing attention to this Rémi.

    I'm a bit concerned that it might be a bit late into the 3.9 beta to incorporate a removal and that we might need to consider delaying to 3.10, but I'll leave that up to Lukasz. Feel free to open a PR in the meantime since it will need to be removed either way, the only main difference is whether or not it gets backported to 3.9.

    (I elevated the priority to "release blocker", as I think it should be a blocker for 3.10 if it's not for 3.9. The version should be updated accordingly.)

    @remilapeyre
    Copy link
    Mannequin Author

    remilapeyre mannequin commented Jun 27, 2020

    With beta 4 coming in 2 days it would perhaps good to choose now whether this must be done for 3.9 or 3.10

    @aeros
    Copy link
    Contributor

    aeros commented Jun 28, 2020

    With beta 4 coming in 2 days it would perhaps good to choose now whether this must be done for 3.9 or 3.10

    Agreed. I'm definitely leaning towards 3.10 with it being decently well into the beta, but I'll try to bring this to Yury's attention to make a final decision on the matter. Optimally, we want to do removals before the beta so that users can prepare accordingly rather than deal with breakage in the final release.

    @1st1
    Copy link
    Member

    1st1 commented Jun 29, 2020

    Optimally, we want to do removals before the beta so that users can prepare accordingly rather than deal with breakage in the final release.

    +1 to remove it now. Up to Lukasz to give us green or red light here, though.

    @ambv
    Copy link
    Contributor

    ambv commented Jun 29, 2020

    Go ahead.

    @miss-islington
    Copy link
    Contributor

    New changeset 004e64e by Rémi Lapeyre in branch 'master':
    bpo-40967: Remove deprecated asyncio.Task.current_task() and asyncio.Task.all_tasks() (GH-20874)
    004e64e

    @miss-islington
    Copy link
    Contributor

    New changeset df59293 by Miss Islington (bot) in branch '3.9':
    bpo-40967: Remove deprecated asyncio.Task.current_task() and asyncio.Task.all_tasks() (GH-20874)
    df59293

    @aeros
    Copy link
    Contributor

    aeros commented Jul 2, 2020

    Thanks Rémi for working on this.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes topic-asyncio
    Projects
    None yet
    Development

    No branches or pull requests

    5 participants