Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haiku build fix - posix module #85239

Closed
devnexen mannequin opened this issue Jun 21, 2020 · 2 comments
Closed

Haiku build fix - posix module #85239

devnexen mannequin opened this issue Jun 21, 2020 · 2 comments
Labels
3.10 only security fixes build The build process and cross-build extension-modules C modules in the Modules dir

Comments

@devnexen
Copy link
Mannequin

devnexen mannequin commented Jun 21, 2020

BPO 41067
Nosy @gpshead, @devnexen
PRs
  • bpo-41067: Haiku build fix #21032
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2020-06-21.17:35:06.482>
    labels = ['extension-modules', 'build', '3.10']
    title = 'Haiku build fix - posix module'
    updated_at = <Date 2020-06-21.19:32:01.665>
    user = 'https://github.com/devnexen'

    bugs.python.org fields:

    activity = <Date 2020-06-21.19:32:01.665>
    actor = 'gregory.p.smith'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Extension Modules']
    creation = <Date 2020-06-21.17:35:06.482>
    creator = 'devnexen'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 41067
    keywords = []
    message_count = 1.0
    messages = ['372014']
    nosy_count = 2.0
    nosy_names = ['gregory.p.smith', 'devnexen']
    pr_nums = ['21032']
    priority = 'normal'
    resolution = None
    stage = None
    status = 'open'
    superseder = None
    type = 'compile error'
    url = 'https://bugs.python.org/issue41067'
    versions = ['Python 3.10']

    @devnexen devnexen mannequin added 3.10 only security fixes extension-modules C modules in the Modules dir build The build process and cross-build labels Jun 21, 2020
    @gpshead
    Copy link
    Member

    gpshead commented Jun 21, 2020

    This type of change might make more sense to integrate into configure.ac and pyconfig.h.in. (does haiku use autoconf?)

    But even if not, lets not scatter haiku ifdef HAIKU references all over the codebase. Such ifdef's to redefine things should be lumped in a single maintainable spot in a given file, and if needed in multiple files they belong in a header.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @iritkatriel
    Copy link
    Member

    Closing along with the PR as this seems to have been abandoned by the OP.

    @iritkatriel iritkatriel closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 only security fixes build The build process and cross-build extension-modules C modules in the Modules dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants