msilib does not work correctly with non-ASCII names

[serhiy-storchaka]

BPO	41074
Nosy	@pfmoore, @tjguk, @zware, @serhiy-storchaka, @zooba, @miss-islington
PRs	bpo-41074: Fix support of non-ASCII names and SQL in msilib. #21126 [3.9] bpo-41074: Fix support of non-ASCII names and SQL in msilib. (GH-21126) #21133 [3.8] bpo-41074: Fix support of non-ASCII names and SQL in msilib. (GH-21126) #21134

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-06-25.09:14:07.155>
created_at = <Date 2020-06-22.09:49:24.746>
labels = ['type-bug', '3.8', '3.9', '3.10', 'extension-modules', 'OS-windows']
title = 'msilib does not work correctly with non-ASCII names'
updated_at = <Date 2020-06-25.09:14:07.154>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2020-06-25.09:14:07.154>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2020-06-25.09:14:07.155>
closer = 'serhiy.storchaka'
components = ['Extension Modules', 'Windows']
creation = <Date 2020-06-22.09:49:24.746>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 41074
keywords = ['patch']
message_count = 5.0
messages = ['372083', '372306', '372312', '372313', '372314']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'serhiy.storchaka', 'steve.dower', 'miss-islington']
pr_nums = ['21126', '21133', '21134']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41074'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

[serhiy-storchaka]

It encodes input string arguments with utf-8 and pass encoded strings to 8-bit API which expect they be encoded using the locale encoding. It may pass tests, create and read files, but these files will just have wrong names.

[serhiy-storchaka]

New changeset 55939b1 by Serhiy Storchaka in branch 'master':
bpo-41074: Fix support of non-ASCII names and SQL in msilib. (GH-21126)
55939b1

[miss-islington]

New changeset 3f4de44 by Miss Islington (bot) in branch '3.8':
bpo-41074: Fix support of non-ASCII names and SQL in msilib. (GH-21126)
3f4de44

[miss-islington]

New changeset 0ef6a3f by Miss Islington (bot) in branch '3.9':
bpo-41074: Fix support of non-ASCII names and SQL in msilib. (GH-21126)
0ef6a3f

[serhiy-storchaka]

There are also problems with FCICreate, but this is a different issue.