pdb's whatis command reports method as function

[iritkatriel]

BPO	41609
Nosy	@ambv, @miss-islington, @isidentical, @iritkatriel
PRs	bpo-41609: Fix output of pdb's whatis command for instance methods #21935 [3.8] bpo-41609: Fix output of pdb's whatis command for instance methods (GH-21935) #21976 [3.9] bpo-41609: Fix output of pdb's whatis command for instance methods (GH-21935) #21977

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-08-27.01:18:12.143>
created_at = <Date 2020-08-21.15:31:01.652>
labels = ['3.8', 'type-bug', 'library', '3.9', '3.10']
title = "pdb's whatis command reports method as function"
updated_at = <Date 2020-08-27.01:18:33.817>
user = 'https://github.com/iritkatriel'

bugs.python.org fields:

activity = <Date 2020-08-27.01:18:33.817>
actor = 'lukasz.langa'
assignee = 'none'
closed = True
closed_date = <Date 2020-08-27.01:18:12.143>
closer = 'lukasz.langa'
components = ['Library (Lib)']
creation = <Date 2020-08-21.15:31:01.652>
creator = 'iritkatriel'
dependencies = []
files = []
hgrepos = []
issue_num = 41609
keywords = ['patch']
message_count = 7.0
messages = ['375756', '375757', '375815', '375972', '375975', '375976', '375977']
nosy_count = 4.0
nosy_names = ['lukasz.langa', 'miss-islington', 'BTaskaya', 'iritkatriel']
pr_nums = ['21935', '21976', '21977']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41609'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

[iritkatriel]

pdb's whatis command prints 'Function' instead of 'Method' for a bound method:

> python.bat
Running Release|Win32 interpreter...
Python 3.10.0a0 (heads/master-dirty:12695f4c6d, Aug 21 2020, 15:48:06) [MSC v.1916 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> class MyClass:
...     def mymethod(self):
...         pass
...
>>> import pdb
>>> pdb.set_trace()
--Return--
> <stdin>(1)<module>()->None
(Pdb) whatis MyClass().mymethod
Function mymethod
(Pdb) MyClass().mymethod
<bound method MyClass.mymethod of <__main__.MyClass object at 0x0131D5C8>>
(Pdb)

[iritkatriel]

The reason for this that it first checks whether there is a __code__ attribute (which both methods and functions have) and only afterwards checks for __func__.__code__.

I will submit a patch with a test and fix shortly.

[iritkatriel]

It should really use inspect.* functions but I think that should be done separately from this fix.

[ambv]

New changeset 022bc75 by Irit Katriel in branch 'master':
bpo-41609: Fix output of pdb's whatis command for instance methods (GH-21935)
022bc75

[ambv]

New changeset 641279e by Miss Islington (bot) in branch '3.8':
bpo-41609: Fix output of pdb's whatis command for instance methods (GH-21935) (bpo-21976)
641279e

[ambv]

New changeset 7361451 by Miss Islington (bot) in branch '3.9':
bpo-41609: Fix output of pdb's whatis command for instance methods (GH-21935) (bpo-21977)
7361451

[ambv]

Thank you for your contribution, Irit!