Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shutil.copy documentation should clarify support for path-like objects #85812

Closed
JonatanSkogsfors mannequin opened this issue Aug 27, 2020 · 6 comments
Closed

shutil.copy documentation should clarify support for path-like objects #85812

JonatanSkogsfors mannequin opened this issue Aug 27, 2020 · 6 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@JonatanSkogsfors
Copy link
Mannequin

JonatanSkogsfors mannequin commented Aug 27, 2020

BPO 41646
Nosy @methane, @zooba, @jonatanskogsfors, @ZackerySpytz, @miss-islington, @tirkarthi
PRs
  • bpo-41646: Mention path-like objects support in the docs for shutil.copy() #22208
  • [3.9] bpo-41646: Mention path-like objects support in the docs for shutil.copy() (GH-22208) #22243
  • [3.8] bpo-41646: Mention path-like objects support in the docs for shutil.copy() (GH-22208) #22244
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2020-09-14.19:31:13.813>
    created_at = <Date 2020-08-27.09:53:46.800>
    labels = ['type-bug', '3.8', '3.9', '3.10', 'docs']
    title = 'shutil.copy documentation should clarify support for path-like objects'
    updated_at = <Date 2020-10-21.05:16:50.304>
    user = 'https://github.com/jonatanskogsfors'

    bugs.python.org fields:

    activity = <Date 2020-10-21.05:16:50.304>
    actor = 'methane'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2020-09-14.19:31:13.813>
    closer = 'steve.dower'
    components = ['Documentation']
    creation = <Date 2020-08-27.09:53:46.800>
    creator = 'Jonatan Skogsfors'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 41646
    keywords = ['patch']
    message_count = 6.0
    messages = ['375983', '375987', '376892', '376894', '379191', '379192']
    nosy_count = 7.0
    nosy_names = ['methane', 'docs@python', 'steve.dower', 'Jonatan Skogsfors', 'ZackerySpytz', 'miss-islington', 'xtreak']
    pr_nums = ['22208', '22243', '22244']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue41646'
    versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

    @JonatanSkogsfors
    Copy link
    Mannequin Author

    JonatanSkogsfors mannequin commented Aug 27, 2020

    In the 3.8.5 documentation for shutil.copy it says that "src and dst should be strings". However, the implementation doesn't seem to have any problem with path objects.

    @JonatanSkogsfors JonatanSkogsfors mannequin added the 3.8 only security fixes label Aug 27, 2020
    @JonatanSkogsfors JonatanSkogsfors mannequin added docs Documentation in the Doc dir 3.8 only security fixes labels Aug 27, 2020
    @JonatanSkogsfors JonatanSkogsfors mannequin added the docs Documentation in the Doc dir label Aug 27, 2020
    @tirkarthi
    Copy link
    Member

    copy uses copyfile and copymode. Both were updated to support path-like objects in #15141 . It makes sense to update copy's documentation too.

    @tirkarthi tirkarthi added 3.9 only security fixes 3.10 only security fixes labels Aug 27, 2020
    @tirkarthi tirkarthi changed the title Outdated shutil.copy documentation shutil.copy documentation should clarify support for path-like objects Aug 27, 2020
    @tirkarthi tirkarthi added type-bug An unexpected behavior, bug, or error 3.9 only security fixes 3.10 only security fixes labels Aug 27, 2020
    @tirkarthi tirkarthi changed the title Outdated shutil.copy documentation shutil.copy documentation should clarify support for path-like objects Aug 27, 2020
    @tirkarthi tirkarthi added the type-bug An unexpected behavior, bug, or error label Aug 27, 2020
    @zooba
    Copy link
    Member

    zooba commented Sep 14, 2020

    New changeset 8f2b991 by Zackery Spytz in branch 'master':
    bpo-41646: Mention path-like objects support in the docs for shutil.copy() (GH-22208)
    8f2b991

    @zooba
    Copy link
    Member

    zooba commented Sep 14, 2020

    Thanks!

    @zooba zooba closed this as completed Sep 14, 2020
    @zooba zooba closed this as completed Sep 14, 2020
    @methane
    Copy link
    Member

    methane commented Oct 21, 2020

    New changeset 6443a8c by Miss Skeleton (bot) in branch '3.8':
    bpo-41646: Mention path-like objects support in the docs for shutil.copy() (GH-22208)
    6443a8c

    @methane
    Copy link
    Member

    methane commented Oct 21, 2020

    New changeset 19019ec by Miss Skeleton (bot) in branch '3.9':
    bpo-41646: Mention path-like objects support in the docs for shutil.copy() (GH-22208)
    19019ec

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants