Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for typing.ForwardRef don't state that it was added in 3.7 #85990

Closed
dom1310df mannequin opened this issue Sep 21, 2020 · 6 comments
Closed

Docs for typing.ForwardRef don't state that it was added in 3.7 #85990

dom1310df mannequin opened this issue Sep 21, 2020 · 6 comments
Labels
3.7 (EOL) end of life docs Documentation in the Doc dir

Comments

@dom1310df
Copy link
Mannequin

dom1310df mannequin commented Sep 21, 2020

BPO 41824
Nosy @gvanrossum, @Fidget-Spinner
PRs
  • bpo-41824: Add versionadded for typing.ForwardRef docs #24224
  • [3.9] bpo-41824: Add versionadded for typing.ForwardRef docs (GH-24224) #24493
  • [3.8] bpo-41824: Add versionadded for typing.ForwardRef docs (GH-24224) #24494
  • [3.8] bpo-41824: Fix indentation issue in ForwardRef docs #24495
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-02-09.19:02:00.442>
    created_at = <Date 2020-09-21.16:35:27.069>
    labels = ['3.7', 'docs']
    title = "Docs for typing.ForwardRef don't state that it was added in 3.7"
    updated_at = <Date 2021-02-09.19:02:00.441>
    user = 'https://bugs.python.org/dom1310df'

    bugs.python.org fields:

    activity = <Date 2021-02-09.19:02:00.441>
    actor = 'gvanrossum'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2021-02-09.19:02:00.442>
    closer = 'gvanrossum'
    components = ['Documentation']
    creation = <Date 2020-09-21.16:35:27.069>
    creator = 'dom1310df'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 41824
    keywords = ['patch']
    message_count = 6.0
    messages = ['377262', '386686', '386728', '386729', '386731', '386732']
    nosy_count = 4.0
    nosy_names = ['gvanrossum', 'docs@python', 'dom1310df', 'kj']
    pr_nums = ['24224', '24493', '24494', '24495']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue41824'
    versions = ['Python 3.6', 'Python 3.7']

    @dom1310df
    Copy link
    Mannequin Author

    dom1310df mannequin commented Sep 21, 2020

    typing.ForwardRef was first documented in #58424 but there's no mention that the class was only added in Python 3.7.

    In Python 3.6 there's no typing.ForwardRef; there is a typing._ForwardRef which seems to be the same thing from before it was made public.

    What I don't know is whether the change of name was made in 3.7 or in a point release.

    @dom1310df dom1310df mannequin added stdlib Python modules in the Lib dir 3.7 (EOL) end of life labels Sep 21, 2020
    @iritkatriel iritkatriel added docs Documentation in the Doc dir and removed stdlib Python modules in the Lib dir labels Sep 21, 2020
    @iritkatriel iritkatriel changed the title Docs for typing.ForwardRef don't state that is was added in 3.7 Docs for typing.ForwardRef don't state that it was added in 3.7 Sep 21, 2020
    @iritkatriel iritkatriel added docs Documentation in the Doc dir and removed stdlib Python modules in the Lib dir labels Sep 21, 2020
    @iritkatriel iritkatriel changed the title Docs for typing.ForwardRef don't state that is was added in 3.7 Docs for typing.ForwardRef don't state that it was added in 3.7 Sep 21, 2020
    @gvanrossum
    Copy link
    Member

    New changeset da21f7b by Ken Jin in branch 'master':
    bpo-41824: Add versionadded for typing.ForwardRef docs (bpo-24224)
    da21f7b

    @gvanrossum
    Copy link
    Member

    New changeset 917eca7 by Ken Jin in branch '3.9':
    bpo-41824: Add versionadded for typing.ForwardRef docs (bpo-24224) (bpo-24493)
    917eca7

    @gvanrossum
    Copy link
    Member

    New changeset c8a48c6 by Ken Jin in branch '3.8':
    [3.8] bpo-41824: Add versionadded for typing.ForwardRef docs (bpo-24224) (bpo-24494)
    c8a48c6

    @gvanrossum
    Copy link
    Member

    New changeset 822f7c2 by Ken Jin in branch '3.8':
    [3.8] bpo-41824: Fix indentation issue in ForwardRef docs (bpo-24495)
    822f7c2

    @Fidget-Spinner
    Copy link
    Member

    I think we can close this now. Thanks for reporting it Dominic, and thanks Guido for all your help!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life docs Documentation in the Doc dir
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants