A missing "goto" in the _ssl module!

[ZackerySpytz]

BPO	42144
Nosy	@tiran, @ZackerySpytz, @miss-islington
PRs	bpo-42144: Add a missing "goto error;" in the _ssl module #22959 [3.9] bpo-42144: Add a missing "goto error;" in the _ssl module (GH-22959) #22974 [3.8] bpo-42144: Add a missing "goto error;" in the _ssl module (GH-22959) #22975

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tiran'
closed_at = <Date 2020-10-25.20:38:29.450>
created_at = <Date 2020-10-25.04:51:47.617>
labels = ['expert-SSL', 'type-bug', '3.8', '3.9', '3.10', 'extension-modules']
title = 'A missing "goto" in the _ssl module!'
updated_at = <Date 2020-10-25.20:38:29.449>
user = 'https://github.com/ZackerySpytz'

bugs.python.org fields:

activity = <Date 2020-10-25.20:38:29.449>
actor = 'christian.heimes'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2020-10-25.20:38:29.450>
closer = 'christian.heimes'
components = ['Extension Modules', 'SSL']
creation = <Date 2020-10-25.04:51:47.617>
creator = 'ZackerySpytz'
dependencies = []
files = []
hgrepos = []
issue_num = 42144
keywords = ['patch']
message_count = 5.0
messages = ['379562', '379593', '379594', '379596', '379606']
nosy_count = 3.0
nosy_names = ['christian.heimes', 'ZackerySpytz', 'miss-islington']
pr_nums = ['22959', '22974', '22975']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue42144'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

[ZackerySpytz]

In the _ssl_configure_hostname() function, there's a missing "goto error;" if
SSL_set_tlsext_host_name() fails.

[miss-islington]

New changeset c32f297 by Zackery Spytz in branch 'master':
bpo-42144: Add a missing "goto error;" in the _ssl module (GH-22959)
c32f297

[miss-islington]

New changeset 8e980ec by Miss Skeleton (bot) in branch '3.8':
bpo-42144: Add a missing "goto error;" in the _ssl module (GH-22959)
8e980ec

[miss-islington]

New changeset 83c86cf by Miss Skeleton (bot) in branch '3.9':
bpo-42144: Add a missing "goto error;" in the _ssl module (GH-22959)
83c86cf

[tiran]

Thanks, excellent finding.