Question about deserializing some numbers (bug??)

[hyoxt121]

BPO	42168
Nosy	@ericvsmith, @hyoxt121

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-10-27.14:15:54.358>
created_at = <Date 2020-10-27.10:10:42.115>
labels = ['invalid', 'type-bug', 'library']
title = 'Question about deserializing some numbers (bug??)'
updated_at = <Date 2020-10-27.14:29:50.691>
user = 'https://github.com/hyoxt121'

bugs.python.org fields:

activity = <Date 2020-10-27.14:29:50.691>
actor = 'eric.smith'
assignee = 'none'
closed = True
closed_date = <Date 2020-10-27.14:15:54.358>
closer = 'eric.smith'
components = ['Library (Lib)']
creation = <Date 2020-10-27.10:10:42.115>
creator = 'hyoxt121'
dependencies = []
files = []
hgrepos = []
issue_num = 42168
keywords = []
message_count = 4.0
messages = ['379750', '379752', '379760', '379761']
nosy_count = 2.0
nosy_names = ['eric.smith', 'hyoxt121']
pr_nums = []
priority = 'normal'
resolution = 'not a bug'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue42168'
versions = ['Python 3.6']

[hyoxt121]

Hi! In order to deserialize bytes object, we use pickle.loads():

import pickle
import numpy as np
pickle.loads(np.float64(0.34103))

and the expected result is like below (because np.float64(0.34103) is not bytes objects, appropriate errors are expected)
---------------------------------------------------------------------------

UnpicklingError Traceback (most recent call last)
<ipython-input-19-5c07606a60f1> in <module>
----> 1 pickle.loads(np.float64(0.34103))

UnpicklingError: invalid load key, '\xc1'.

Here we have some questions that some numbers (it is rare) like 0.34104 prints the following result without errors.
pickle.loads(np.float64(0.34104))
=> True

This occurs only when the converted bytes start with b'\x88 (for example 0.04263, 0.08526, 0.11651 ...)
np.float64(0.34104).tobytes()
=> b'\x88.\xa8o\x99\xd3\xd5?'
Can anyone answer whether this issue is Python bugs?

Any answer will be highly appreciated.

[hyoxt121]

Can anyone explain "pickle.loads(np.float64(0.34104))" prints "True"?

[ericvsmith]

I explained this in https://bugs.python.org/issue42165#msg379755

This is not a bug in python, it's a bug in your code. You should not expect to unpickle something that wasn't created by pickling it.

[ericvsmith]

Or stated differently: if you pass random byte strings to pickle.loads(), sometimes it might succeed and produce a random object because you've managed to create a valid pickle. But most often it will fail.