os.statvfs_result doesn't show f_fsid

[Rethan]

BPO	42461
Nosy	@tiran, @Rethan
PRs	bpo-42461: show f_fsid when pring os.statvfs object #23511

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2020-11-25.10:06:55.159>
labels = ['type-bug', 'library', '3.10']
title = "os.statvfs_result doesn't show f_fsid"
updated_at = <Date 2020-12-04.10:42:23.909>
user = 'https://github.com/Rethan'

bugs.python.org fields:

activity = <Date 2020-12-04.10:42:23.909>
actor = 'Rethan'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2020-11-25.10:06:55.159>
creator = 'Rethan'
dependencies = []
files = []
hgrepos = []
issue_num = 42461
keywords = ['patch']
message_count = 4.0
messages = ['381811', '381815', '381876', '382473']
nosy_count = 2.0
nosy_names = ['christian.heimes', 'Rethan']
pr_nums = ['23511']
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue42461'
versions = ['Python 3.10']

[Rethan]

From doc I see about os.statvfs "New in version 3.7: Added f_fsid.", but it doesn't show up when print an object os.statvfs returned. So I think maybe we can add the field when printing object.

[tiran]

Changeset 96a5e50 added a new struct member but did not increase PyStructSequence_Desc.n_in_sequence of
statvfs_result_desc. I'm not sure if the size of the sequence was not increased on purpose.

For reference the feature was added in bpo-32143.

[Rethan]

Under my mac and fedora test environment, calling statfs in C language as a non-privileged user both returned meaningful fsid. And in python os.statvfs(some_path).f_fsid can also show the f_fsid of path. So I didn't see any inconveniences so far if object print shows it.

[Rethan]

hi christian, is there any future suggestions?