Dead assignment in idna_converter function

[alexhenrie]

BPO	43361
Nosy	@alexhenrie, @iritkatriel
PRs	bpo-43361: Remove dead assignment from idna_converter function #24701

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2021-03-02.02:29:09.605>
labels = ['type-feature', 'library', '3.10']
title = 'Dead assignment in idna_converter function'
updated_at = <Date 2022-01-29.23:51:42.236>
user = 'https://github.com/alexhenrie'

bugs.python.org fields:

activity = <Date 2022-01-29.23:51:42.236>
actor = 'iritkatriel'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2021-03-02.02:29:09.605>
creator = 'alex.henrie'
dependencies = []
files = []
hgrepos = []
issue_num = 43361
keywords = ['patch']
message_count = 2.0
messages = ['387896', '412109']
nosy_count = 2.0
nosy_names = ['alex.henrie', 'iritkatriel']
pr_nums = ['24701']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue43361'
versions = ['Python 3.10']

[alexhenrie]

The idna_converter function in socketmodule.c currently initializes the variable len to -1, then reinitializes it on every path that uses it. The first initialization could be removed to simplify the code and clarify its intent.

Defect identified by scan-build <https://clang-analyzer.llvm.org/scan-build.html\>

[iritkatriel]

I don't think removing this will make the code easier to read. It's an exercise to verify that all the different if-else branches set this variable.

[kumaraditya303]

Yeah, the existing code is better.