Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self.assertDictContainsSubset warning is unhelpful #88461

Closed
asottile mannequin opened this issue Jun 2, 2021 · 2 comments
Closed

self.assertDictContainsSubset warning is unhelpful #88461

asottile mannequin opened this issue Jun 2, 2021 · 2 comments
Labels
3.10 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@asottile
Copy link
Mannequin

asottile mannequin commented Jun 2, 2021

BPO 44295
Nosy @asottile
PRs
  • [3.10] bpo-44295: ensure deprecation warning from assertDictContainsSubset points at actual test code #26497
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-11-16.03:11:19.316>
    created_at = <Date 2021-06-02.23:32:40.294>
    labels = ['type-bug', 'library', '3.10']
    title = 'self.assertDictContainsSubset warning is unhelpful'
    updated_at = <Date 2021-11-16.03:11:19.315>
    user = 'https://github.com/asottile'

    bugs.python.org fields:

    activity = <Date 2021-11-16.03:11:19.315>
    actor = 'rhettinger'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-11-16.03:11:19.316>
    closer = 'rhettinger'
    components = ['Library (Lib)']
    creation = <Date 2021-06-02.23:32:40.294>
    creator = 'Anthony Sottile'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 44295
    keywords = ['patch']
    message_count = 2.0
    messages = ['394953', '405479']
    nosy_count = 1.0
    nosy_names = ['Anthony Sottile']
    pr_nums = ['26497']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue44295'
    versions = ['Python 3.10']

    @asottile
    Copy link
    Mannequin Author

    asottile mannequin commented Jun 2, 2021

    it's missing stacklevel= -- mostly creating a bpo issue to link to

    @asottile asottile mannequin added 3.11 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Jun 2, 2021
    @asottile
    Copy link
    Mannequin Author

    asottile mannequin commented Nov 2, 2021

    looks like this was removed in 3.11 -- wondering if it's still worth correcting the deprecation warning location

    @asottile asottile mannequin added 3.10 only security fixes and removed 3.11 only security fixes labels Nov 2, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant