Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for yescrypt in crypt. #88475

Closed
besser82 mannequin opened this issue Jun 4, 2021 · 4 comments
Closed

Add support for yescrypt in crypt. #88475

besser82 mannequin opened this issue Jun 4, 2021 · 4 comments
Labels
3.11 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@besser82
Copy link
Mannequin

besser82 mannequin commented Jun 4, 2021

BPO 44309
Nosy @tiran, @dseomn, @besser82
PRs
  • bpo-44309: Add support for yescrypt in crypt. #26526
  • [3.10] bpo-44309: Add support for yescrypt in crypt. (GH-26526) #26527
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2021-06-04.11:10:28.051>
    labels = ['type-feature', 'library', '3.11']
    title = 'Add support for yescrypt in crypt.'
    updated_at = <Date 2021-09-23.19:43:10.780>
    user = 'https://github.com/besser82'

    bugs.python.org fields:

    activity = <Date 2021-09-23.19:43:10.780>
    actor = 'dseomn'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2021-06-04.11:10:28.051>
    creator = 'besser82'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 44309
    keywords = ['patch']
    message_count = 2.0
    messages = ['395073', '395160']
    nosy_count = 4.0
    nosy_names = ['jafo', 'christian.heimes', 'dseomn', 'besser82']
    pr_nums = ['26526', '26527']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue44309'
    versions = ['Python 3.11']

    @besser82
    Copy link
    Mannequin Author

    besser82 mannequin commented Jun 4, 2021

    Proposed PR adds support for a new method in the crypt module:

    yescrypt. It is considered stronger as SHA512 or blowfish and as strong as argon2 for crypt() purpose. The hashing method was developed by the author of the blowfish crypt method, and was based on scrypt. It is supported on most Linux distributions, that ship with libxcrypt as a replacement for the glibc crypt library: Fedora, Debian, Ubuntu, OpenSUSE and many others.

    @besser82 besser82 mannequin added 3.10 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Jun 4, 2021
    @serhiy-storchaka serhiy-storchaka added 3.11 only security fixes and removed 3.10 only security fixes labels Jun 5, 2021
    @tiran
    Copy link
    Member

    tiran commented Jun 5, 2021

    I'm against adding additional methods to the crypt module.

    • libcrypt / libxcrypt are unreliable providers. The library is only available on Unix-like platforms, not on Windows. Available algorithms are not consistent, e.g. some platforms only provide old, bad implementations. Others only support a limited subset or disable some algorithms in their crypto policies.
    • We still plan to deprecate and remove the crypt module because it's not reliable.

    I suggest that you rather create a PyPI package with yescrypt implementation that does not rely on libcrypt.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @AlexWaygood
    Copy link
    Member

    The crypt module is now deprecated following the acceptance of PEP 594 by the Steering Council. As such, bugfixes and improvements to the module will no longer be accepted; I am therefore closing this issue.

    @AlexWaygood
    Copy link
    Member

    The crypt module is now deprecated following the acceptance of PEP 594 by the Steering Council. As such, bugfixes and improvements to the module will no longer be accepted; I am therefore closing this issue.

    Cc. @dseomn, @besser82

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants