Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some target-related rules are unreachable in the grammar #88551

Closed
lysnikolaou opened this issue Jun 10, 2021 · 4 comments
Closed

Some target-related rules are unreachable in the grammar #88551

lysnikolaou opened this issue Jun 10, 2021 · 4 comments
Assignees
Labels
3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@lysnikolaou
Copy link
Contributor

BPO 44385
Nosy @gvanrossum, @lysnikolaou, @pablogsal, @miss-islington
PRs
  • bpo-44385: Remove unused grammar rules #26655
  • [3.10] bpo-44385: Remove unused grammar rules (GH-26655) #26657
  • [3.9] bpo-44385: Remove unused grammar rules (GH-26655) #26659
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/lysnikolaou'
    closed_at = <Date 2021-06-10.22:38:54.008>
    created_at = <Date 2021-06-10.21:42:26.760>
    labels = ['interpreter-core', 'type-bug', '3.11']
    title = 'Some target-related rules are unreachable in the grammar'
    updated_at = <Date 2021-06-10.22:52:56.372>
    user = 'https://github.com/lysnikolaou'

    bugs.python.org fields:

    activity = <Date 2021-06-10.22:52:56.372>
    actor = 'miss-islington'
    assignee = 'lys.nikolaou'
    closed = True
    closed_date = <Date 2021-06-10.22:38:54.008>
    closer = 'lys.nikolaou'
    components = ['Parser']
    creation = <Date 2021-06-10.21:42:26.760>
    creator = 'lys.nikolaou'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 44385
    keywords = ['patch']
    message_count = 4.0
    messages = ['395577', '395581', '395582', '395586']
    nosy_count = 4.0
    nosy_names = ['gvanrossum', 'lys.nikolaou', 'pablogsal', 'miss-islington']
    pr_nums = ['26655', '26657', '26659']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue44385'
    versions = ['Python 3.11']

    @lysnikolaou
    Copy link
    Contributor Author

    Three rules (targets, target and t_atom) in the grammar are unreachable. We were using them at some point in the past, but we never removed them when we replaced them with other rules.

    @lysnikolaou lysnikolaou added the 3.11 only security fixes label Jun 10, 2021
    @lysnikolaou lysnikolaou self-assigned this Jun 10, 2021
    @lysnikolaou lysnikolaou added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error 3.11 only security fixes labels Jun 10, 2021
    @lysnikolaou lysnikolaou self-assigned this Jun 10, 2021
    @lysnikolaou lysnikolaou added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Jun 10, 2021
    @miss-islington
    Copy link
    Contributor

    New changeset e7b4644 by Lysandros Nikolaou in branch 'main':
    bpo-44385: Remove unused grammar rules (GH-26655)
    e7b4644

    @miss-islington
    Copy link
    Contributor

    New changeset 3e13742 by Miss Islington (bot) in branch '3.10':
    bpo-44385: Remove unused grammar rules (GH-26655)
    3e13742

    @miss-islington
    Copy link
    Contributor

    New changeset 3ce35bf by Lysandros Nikolaou in branch '3.9':
    [3.9] bpo-44385: Remove unused grammar rules (GH-26655) (GH-26659)
    3ce35bf

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants