Failed tee.fromiterable() corrupts the linked list of all GC objects in debug build

[serhiy-storchaka]

BPO	44563
Nosy	@rhettinger, @serhiy-storchaka, @pablogsal, @miss-islington, @Fidget-Spinner
PRs	bpo-44563: Fix error handling in tee.fromiterable() #27020 [3.10] bpo-44563: Fix error handling in tee.fromiterable() (GH-27020) #27041 [3.9] bpo-44563: Fix error handling in tee.fromiterable() (GH-27020) #27042

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-07-05.22:43:26.994>
created_at = <Date 2021-07-04.18:11:14.292>
labels = ['extension-modules', '3.10', '3.9', 'type-crash', '3.11']
title = 'Failed tee.fromiterable() corrupts the linked list of all GC objects in debug build'
updated_at = <Date 2021-07-05.22:43:26.994>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2021-07-05.22:43:26.994>
actor = 'pablogsal'
assignee = 'none'
closed = True
closed_date = <Date 2021-07-05.22:43:26.994>
closer = 'pablogsal'
components = ['Extension Modules']
creation = <Date 2021-07-04.18:11:14.292>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 44563
keywords = ['patch']
message_count = 4.0
messages = ['396952', '397023', '397026', '397027']
nosy_count = 5.0
nosy_names = ['rhettinger', 'serhiy.storchaka', 'pablogsal', 'miss-islington', 'kj']
pr_nums = ['27020', '27041', '27042']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue44563'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

[serhiy-storchaka]

In tee.fromiterable() the non-initialized tee object can be deleted by without calling _Py_ForgetReference() in debug build.

See also bpo-44553 and bpo-44562.

The proposed PR rewrites the code so that it no longer need to delete not completely initialized tee object.

[pablogsal]

New changeset f64de53 by Serhiy Storchaka in branch 'main':
bpo-44563: Fix error handling in tee.fromiterable() (GH-27020)
f64de53

[pablogsal]

New changeset 324b932 by Miss Islington (bot) in branch '3.9':
bpo-44563: Fix error handling in tee.fromiterable() (GH-27020) (GH-27042)
324b932

[pablogsal]

New changeset 645e527 by Miss Islington (bot) in branch '3.10':
bpo-44563: Fix error handling in tee.fromiterable() (GH-27020) (GH-27041)
645e527