Recursion causes Crash

[michaeljwang10]

BPO	44790
Nosy	@sweeneyde, @jdevries3133
Files	bug.py: Use the following code to replicate the bug

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-07-31.03:45:52.992>
created_at = <Date 2021-07-31.02:20:58.105>
labels = ['interpreter-core', '3.7', 'invalid', 'type-crash']
title = 'Recursion causes Crash'
updated_at = <Date 2021-07-31.03:45:52.991>
user = 'https://bugs.python.org/michaeljwang10'

bugs.python.org fields:

activity = <Date 2021-07-31.03:45:52.991>
actor = 'Dennis Sweeney'
assignee = 'none'
closed = True
closed_date = <Date 2021-07-31.03:45:52.992>
closer = 'Dennis Sweeney'
components = ['Interpreter Core']
creation = <Date 2021-07-31.02:20:58.105>
creator = 'michaeljwang10'
dependencies = []
files = ['50193']
hgrepos = []
issue_num = 44790
keywords = []
message_count = 4.0
messages = ['398619', '398622', '398623', '398627']
nosy_count = 3.0
nosy_names = ['Dennis Sweeney', 'jack__d', 'michaeljwang10']
pr_nums = []
priority = 'normal'
resolution = 'not a bug'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue44790'
versions = ['Python 3.7']

[michaeljwang10]

Ultimately it seems that deep recursion after setting the recursion limit actually crashes python

[jdevries3133]

The default recursion limit is 1,000; you're increasing it by a factor of 10. It is documented that raising the recursion limit can cause crashes. What kind of crash are you seeing? Segmentation fault or stack overflow? Also, provide more details about your system: what OS and more importantly in this case, how much RAM?

It's possible that this is not a bug.

[jdevries3133]

Also, see related: bpo-44393

[sweeneyde]

Indeed, this behavior is documented at https://docs.python.org/3/library/sys.html?highlight=setrecursionlimit#sys.setrecursionlimit : "a too-high limit can lead to a crash".

I'd recommend refactoring to use iteration rather than recursion:

    def fact(n):
        product = 1
        for i in range(1, n+1):
            product *= i
        return product