pyperformance fails to build master

[pablogsal]

BPO	45236
Nosy	@vstinner, @ericsnowcurrently, @pablogsal

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-09-19.19:01:42.613>
created_at = <Date 2021-09-17.20:36:52.638>
labels = []
title = 'pyperformance fails to build master'
updated_at = <Date 2021-09-19.19:01:42.612>
user = 'https://github.com/pablogsal'

bugs.python.org fields:

activity = <Date 2021-09-19.19:01:42.612>
actor = 'pablogsal'
assignee = 'none'
closed = True
closed_date = <Date 2021-09-19.19:01:42.613>
closer = 'pablogsal'
components = []
creation = <Date 2021-09-17.20:36:52.638>
creator = 'pablogsal'
dependencies = []
files = []
hgrepos = []
issue_num = 45236
keywords = []
message_count = 3.0
messages = ['402089', '402093', '402161']
nosy_count = 3.0
nosy_names = ['vstinner', 'eric.snow', 'pablogsal']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue45236'
versions = []

[pablogsal]

In the main branch, pyperformance fails to build due to something regarding the freeze module:

2021-09-17 00:03:46,170: /home/pablogsal/cpython_cron/Programs/_freeze_module importlib._bootstrap /home/pablogsal/cpython_cron/Lib/importlib/_bootstrap.py /home/pablogsal/cpython_cron/Python/frozen_modules/importlib__bootstrap.h
2021-09-17 00:03:46,170: make[3]: /home/pablogsal/cpython_cron/Programs/_freeze_module: Command not found
2021-09-17 00:03:46,170: Makefile:766: recipe for target 'Python/frozen_modules/importlib__bootstrap.h' failed
2021-09-17 00:03:46,171: make[3]: *** [Python/frozen_modules/importlib__bootstrap.h] Error 127
2021-09-17 00:03:46,171: make[3]: Leaving directory '/home/pablogsal/bench_tmpdir_cron/build'
2021-09-17 00:03:46,171: Makefile:535: recipe for target 'build_all_generate_profile' failed
2021-09-17 00:03:46,172: make[2]: *** [build_all_generate_profile] Error 2
2021-09-17 00:03:46,172: make[2]: Leaving directory '/home/pablogsal/bench_tmpdir_cron/build'
2021-09-17 00:03:46,172: Makefile:509: recipe for target 'profile-gen-stamp' failed
2021-09-17 00:03:46,172: make[1]: *** [profile-gen-stamp] Error 2
2021-09-17 00:03:46,172: make[1]: Leaving directory '/home/pablogsal/bench_tmpdir_cron/build'
2021-09-17 00:03:46,172: Makefile:520: recipe for target 'profile-run-stamp' failed
2021-09-17 00:03:46,172: make: *** [profile-run-stamp] Error 2
2021-09-17 00:03:46,173: Command make profile-opt failed with exit code 2
2021-09-17 00:03:46,188: Command /home/pablogsal/venv_cron/bin/python -m pyperformance compile /home/pablogsal/simple.conf fdc6b3d master failed with exit code 11
2021-09-17 00:03:46,188: Benchmark exit code: 11
2021-09-17 00:03:46,188: FAILED: master-fdc6b3d9316501d2f0068a1bf4334debc1949e62

The performance server has been failing from some time due to this problem :(

[vstinner]

I think that I just fixed it with:

commit 41551ee (HEAD -> main, upstream/main)
Author: Victor Stinner <vstinner@python.org>
Date: Fri Sep 17 20:20:43 2021 +0200

bpo-45020: Fix build out of source tree (GH-28410)

* Makefile.pre.in: Add $(srcdir) when needed, remove it when it was
  used by mistake.
* freeze_modules.py tool uses ./Programs/_freeze_module if the
  executable doesn't exist in the source tree.

[pablogsal]

I have checked and indeed this has been fixed already.

Thanks a lot, Victor for the fix!