Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code from html.parser #89584

Closed
mardy mannequin opened this issue Oct 10, 2021 · 2 comments
Closed

Remove dead code from html.parser #89584

mardy mannequin opened this issue Oct 10, 2021 · 2 comments
Labels
3.11 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@mardy
Copy link
Mannequin

mardy mannequin commented Oct 10, 2021

BPO 45421
Nosy @Mariatta, @mardy
PRs
  • bpo-45421: Remove dead code from html.parser #28847
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-10-13.00:22:38.076>
    created_at = <Date 2021-10-10.05:45:37.533>
    labels = ['type-feature', 'library', '3.11']
    title = 'Remove dead code from html.parser'
    updated_at = <Date 2021-10-13.00:22:38.069>
    user = 'https://github.com/mardy'

    bugs.python.org fields:

    activity = <Date 2021-10-13.00:22:38.069>
    actor = 'methane'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-10-13.00:22:38.076>
    closer = 'methane'
    components = ['Library (Lib)']
    creation = <Date 2021-10-10.05:45:37.533>
    creator = 'mardy'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45421
    keywords = ['patch']
    message_count = 2.0
    messages = ['403571', '403745']
    nosy_count = 3.0
    nosy_names = ['python-dev', 'Mariatta', 'mardy']
    pr_nums = ['28847']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue45421'
    versions = ['Python 3.11']

    @mardy
    Copy link
    Mannequin Author

    mardy mannequin commented Oct 10, 2021

    There appears to be some dead code in the html.parser module:

    https://github.com/python/cpython/blob/main/Lib/html/parser.py#L331-L337

    Support for parser errors (with line and offset information) was removed long ago, so this code is useless now. The updatepos() and getpos() methods should also be removed.

    @mardy mardy mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Oct 10, 2021
    @Mariatta
    Copy link
    Member

    New changeset 562c0d7 by Alberto Mardegan in branch 'main':
    bpo-45421: Remove dead code from html.parser (GH-28847)
    562c0d7

    @methane methane added the 3.11 only security fixes label Oct 13, 2021
    @methane methane closed this as completed Oct 13, 2021
    @methane methane added the 3.11 only security fixes label Oct 13, 2021
    @methane methane closed this as completed Oct 13, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants