[C API] Rename CFrame or hide it to only export names starting with Py

[vstinner]

BPO	45431
Nosy	@vstinner, @markshannon, @brandtbucher
PRs	bpo-45431: Rename CFrame to _PyCFrame in the C API #31584

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2022-02-28.15:07:04.281>
created_at = <Date 2021-10-11.09:50:03.542>
labels = ['expert-C-API', '3.11']
title = '[C API] Rename CFrame or hide it to only export names starting with Py'
updated_at = <Date 2022-02-28.15:07:04.281>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2022-02-28.15:07:04.281>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2022-02-28.15:07:04.281>
closer = 'vstinner'
components = ['C API']
creation = <Date 2021-10-11.09:50:03.542>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 45431
keywords = ['patch']
message_count = 8.0
messages = ['403639', '403640', '403642', '403648', '403649', '414000', '414201', '414202']
nosy_count = 3.0
nosy_names = ['vstinner', 'Mark.Shannon', 'brandtbucher']
pr_nums = ['31584']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue45431'
versions = ['Python 3.11']

[vstinner]

#include <Python.h> should only define names which start with "Py" (Py, _Py, PY, _PY), but it now defines a structure called "CFrame" in Include/cpython/pystate.h.

We should either make the whole PyThreadState structure private (move it to the internal C API), or rename CFrame (to PyCFrame?).

[vstinner]

See also bpo-45316: [C API] Functions not exported with PyAPI_FUNC().

[vstinner]

See also the old isssue with "READONLY": bpo-2897 "PyMemberDef missing in limited API / Deprecate structmember.h".

[markshannon]

Struct names aren't exported as symbols.

$ nm ./python | grep CFrame

So, I assume that are worried about name clashes for code that has
#include "Python.h".

Isn't the threadstate struct supposed to be opaque?
If so, then shouldn't it be moved to an internal header?

I don't want to add a "Py" prefix to the name of the CFrame struct.
The names of the various frames are confusing enough, without adding a "Py" prefix to something that isn't a Python frame.

[vstinner]

Mark Shannon:

Struct names aren't exported as symbols.

Right.

So, I assume that are worried about name clashes for code that has
#include "Python.h".

Right :-)

Isn't the threadstate struct supposed to be opaque?

Technically, it's public. I'm working on making it opaque in bpo-39947.

[vstinner]

We should either make the whole PyThreadState structure private (move it to the internal C API), or rename CFrame (to PyCFrame?).

Well, moving PyThreadState to the internal C API is complicate. I prefer to start by renaming CFrame to PyCFrame: see #75765.

[vstinner]

New changeset 7496f95 by Victor Stinner in branch 'main':
bpo-45431: Rename CFrame to _PyCFrame in the C API (GH-31584)
7496f95

[vstinner]

Ok, CFrame has been renamed.

We should either make the whole PyThreadState structure private (move it to the internal C API)

This idea is tracked by bpo-39947.