Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify setup macros for pyexpat and _elementtree #89733

Closed
tiran opened this issue Oct 22, 2021 · 2 comments
Closed

Simplify setup macros for pyexpat and _elementtree #89733

tiran opened this issue Oct 22, 2021 · 2 comments
Assignees
Labels
3.11 build The build process and cross-build type-feature A feature request or enhancement

Comments

@tiran
Copy link
Member

tiran commented Oct 22, 2021

BPO 45570
Nosy @brettcannon, @vstinner, @tiran, @miss-islington
PRs
  • bpo-45570: Simplify setup macros for pyexpat #29159
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
    closed_at = <Date 2021-10-22.16:28:39.616>
    created_at = <Date 2021-10-22.12:40:23.368>
    labels = ['type-feature', 'build', '3.11']
    title = 'Simplify setup macros for pyexpat and _elementtree'
    updated_at = <Date 2021-10-22.16:28:39.616>
    user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2021-10-22.16:28:39.616>
    actor = 'christian.heimes'
    assignee = 'christian.heimes'
    closed = True
    closed_date = <Date 2021-10-22.16:28:39.616>
    closer = 'christian.heimes'
    components = ['Build']
    creation = <Date 2021-10-22.12:40:23.368>
    creator = 'christian.heimes'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45570
    keywords = ['patch']
    message_count = 2.0
    messages = ['404761', '404789']
    nosy_count = 4.0
    nosy_names = ['brett.cannon', 'vstinner', 'christian.heimes', 'miss-islington']
    pr_nums = ['29159']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue45570'
    versions = ['Python 3.11']

    @tiran
    Copy link
    Member Author

    tiran commented Oct 22, 2021

    setup.py and Modules/Setup define a couple of macros for pyexpat and _elementtree. The macros are no longer needed or should be moved to our expat_config.h copy.

    • HAVE_EXPAT_CONFIG_H is not used by our code and not used by system-wide expat header files
    • USE_PYEXPAT_CAPI is no longer used by our code
    • XML_POOR_ENTROPY should be defined in expat_config.h

    @tiran tiran added the 3.11 label Oct 22, 2021
    @tiran tiran self-assigned this Oct 22, 2021
    @tiran tiran added build The build process and cross-build type-feature A feature request or enhancement 3.11 labels Oct 22, 2021
    @tiran tiran self-assigned this Oct 22, 2021
    @tiran tiran added build The build process and cross-build type-feature A feature request or enhancement labels Oct 22, 2021
    @miss-islington
    Copy link
    Contributor

    miss-islington commented Oct 22, 2021

    New changeset ec93721 by Christian Heimes in branch 'main':
    bpo-45570: Simplify setup macros for pyexpat (GH-29159)
    ec93721

    @tiran tiran closed this as completed Oct 22, 2021
    @tiran tiran closed this as completed Oct 22, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants