test_freeze fails if a file is removed

[encukou]

BPO	45783
Nosy	@encukou, @ericsnowcurrently, @hroncok
PRs	bpo-45783: Preserve file moves and deletions in the tests for the freeze tool. #29527

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ericsnowcurrently'
closed_at = <Date 2021-11-23.13:44:16.053>
created_at = <Date 2021-11-11.10:34:54.287>
labels = ['tests', '3.11']
title = 'test_freeze fails if a file is removed'
updated_at = <Date 2021-11-23.13:44:16.053>
user = 'https://github.com/encukou'

bugs.python.org fields:

activity = <Date 2021-11-23.13:44:16.053>
actor = 'petr.viktorin'
assignee = 'eric.snow'
closed = True
closed_date = <Date 2021-11-23.13:44:16.053>
closer = 'petr.viktorin'
components = ['Tests']
creation = <Date 2021-11-11.10:34:54.287>
creator = 'petr.viktorin'
dependencies = []
files = []
hgrepos = []
issue_num = 45783
keywords = ['patch']
message_count = 3.0
messages = ['406151', '406164', '406840']
nosy_count = 3.0
nosy_names = ['petr.viktorin', 'eric.snow', 'hroncok']
pr_nums = ['29527']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue45783'
versions = ['Python 3.11']

[encukou]

In Fedora, we remove the bundled wheels; pip & co. are supplied (and kept updated) by the system. I believe this is good practice.

However, removing any file from the CPython source checkout makes test_freeze fail:

Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-3.11.0a2/Lib/test/test_tools/test_freeze.py", line 25, in test_freeze_simple_script
    outdir, scriptfile, python = helper.prepare(script)
                                 ^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a2/Tools/freeze/test/freeze.py", line 144, in prepare
    git_copy_repo(srcdir, SRCDIR)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a2/Tools/freeze/test/freeze.py", line 97, in git_copy_repo
    shutil.copy2(srcfile, dstfile)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a2/Lib/shutil.py", line 436, in copy2
    copyfile(src, dst, follow_symlinks=follow_symlinks)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/Python-3.11.0a2/Lib/shutil.py", line 256, in copyfile
    with open(src, 'rb') as fsrc:
         ^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/builddir/build/BUILD/Python-3.11.0a2/Lib/ensurepip/_bundled/pip-21.2.4-py3-none-any.whl'

It looks like this test is recreating uncommited modifications, is it OK to change it to support deletions as well?
Also, git status --porcelain should be used to get the output in a stable format.

[ericsnowcurrently]

Thanks for the report, Petr! I'll take a look.

[encukou]

New changeset 8ed1495 by Eric Snow in branch 'main':
bpo-45783: Preserve file moves and deletions in the tests for the freeze tool. (GH-29527)
8ed1495