test_enum contains tests for older versions of python

[sobolevn]

BPO	46327
Nosy	@ethanfurman, @sobolevn
PRs	bpo-46327: remove skipped tests from test_enum #30512

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ethanfurman'
closed_at = <Date 2022-01-10.19:45:16.665>
created_at = <Date 2022-01-10.10:03:42.924>
labels = ['type-bug', 'tests', '3.9', '3.10', '3.11']
title = '`test_enum` contains tests for older versions of python'
updated_at = <Date 2022-01-10.19:45:16.665>
user = 'https://github.com/sobolevn'

bugs.python.org fields:

activity = <Date 2022-01-10.19:45:16.665>
actor = 'sobolevn'
assignee = 'ethan.furman'
closed = True
closed_date = <Date 2022-01-10.19:45:16.665>
closer = 'sobolevn'
components = ['Tests']
creation = <Date 2022-01-10.10:03:42.924>
creator = 'sobolevn'
dependencies = []
files = []
hgrepos = []
issue_num = 46327
keywords = ['patch']
message_count = 3.0
messages = ['410194', '410196', '410246']
nosy_count = 2.0
nosy_names = ['ethan.furman', 'sobolevn']
pr_nums = ['30512']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue46327'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

[sobolevn]

Here's the problem: https://github.com/python/cpython/blob/main/Lib/test/test_enum.py#L4515-L4531

Why it is a problem?

1. First test is marked as @unittest.skipUnless(python_version == (3, 8). Which means it is only executed on 3.8. I think it should be removed from more recent branches
2. Second test is marked as @unittest.skipUnless(python_version >= (3, 9). Which means that it will be executed on three currently supported branches. I think we can remove this decorator

I will send a PR today.

[sobolevn]

On the other hand second test

@unittest.skipUnless(python_version >= (3, 9),
                         '_convert was removed in 3.9')
    def test_convert_raise(self):
        with self.assertRaises(AttributeError):
            enum.IntEnum._convert(
                'UnittestConvert',
                MODULE,
                filter=lambda x: x.startswith('CONVERT_TEST_'))

can also be removed if needed.

[ethanfurman]

New changeset 13e4659 by Nikita Sobolev in branch 'main':
bpo-46327: [Enum] remove skipped tests (GH-30512)
13e4659