Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New compilation warnings on Windows #90504

Closed
gvanrossum opened this issue Jan 11, 2022 · 3 comments
Closed

New compilation warnings on Windows #90504

gvanrossum opened this issue Jan 11, 2022 · 3 comments
Labels
3.11 only security fixes build The build process and cross-build OS-windows type-bug An unexpected behavior, bug, or error

Comments

@gvanrossum
Copy link
Member

BPO 46346
Nosy @gvanrossum, @pfmoore, @vstinner, @tiran, @tjguk, @zware, @zooba, @pablogsal
Superseder
  • bpo-46303: _Py_stat and _Py_wstat using incorrect type for status argument
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2022-01-11.23:11:59.420>
    created_at = <Date 2022-01-11.18:31:57.402>
    labels = ['type-bug', 'OS-windows', 'build', '3.11']
    title = 'New compilation warnings on Windows'
    updated_at = <Date 2022-01-11.23:11:59.419>
    user = 'https://github.com/gvanrossum'

    bugs.python.org fields:

    activity = <Date 2022-01-11.23:11:59.419>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2022-01-11.23:11:59.420>
    closer = 'vstinner'
    components = ['Build', 'Windows']
    creation = <Date 2022-01-11.18:31:57.402>
    creator = 'gvanrossum'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 46346
    keywords = []
    message_count = 3.0
    messages = ['410320', '410325', '410350']
    nosy_count = 8.0
    nosy_names = ['gvanrossum', 'paul.moore', 'vstinner', 'christian.heimes', 'tim.golden', 'zach.ware', 'steve.dower', 'pablogsal']
    pr_nums = []
    priority = None
    resolution = 'duplicate'
    stage = 'resolved'
    status = 'closed'
    superseder = '46303'
    type = 'behavior'
    url = 'https://bugs.python.org/issue46346'
    versions = ['Python 3.11']

    @gvanrossum
    Copy link
    Member Author

    I am getting these warnings:

    C:\Users\gvanrossum\cpython\PC\_testconsole.c(70,38): warning C4013: '_Py_get_osfhandle' undefined; assuming extern returnin
    g int [C:\Users\gvanrossum\cpython\PCbuild\_testconsole.vcxproj]
    C:\Users\gvanrossum\cpython\PC\_testconsole.c(70,1): warning C4047: 'initializing': 'HANDLE' differs in levels of indirectio
    n from 'int' [C:\Users\gvanrossum\cpython\PCbuild\_testconsole.vcxproj]
    C:\Users\gvanrossum\cpython\Modules\_tkinter.c(144,37): warning C4013: '_Py_stat' undefined; assuming extern returning int [
    C:\Users\gvanrossum\cpython\PCbuild\_tkinter.vcxproj]

    I noticed that GitHub also was flagging these in unrelated PRs.

    @gvanrossum gvanrossum added 3.11 only security fixes build The build process and cross-build OS-windows labels Jan 11, 2022
    @zooba
    Copy link
    Member

    zooba commented Jan 11, 2022

    Possibly related to Victor's change in bpo-46303?

    @tiran tiran added release-blocker type-bug An unexpected behavior, bug, or error labels Jan 11, 2022
    @vstinner
    Copy link
    Member

    Oh right, I introduced these warnings in bpo-46303. Let's continue the discussion there.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 only security fixes build The build process and cross-build OS-windows type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants