Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid sporadic failure of test_compileall on Windows #91245

Closed
jkloth opened this issue Mar 21, 2022 · 6 comments
Closed

Avoid sporadic failure of test_compileall on Windows #91245

jkloth opened this issue Mar 21, 2022 · 6 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir

Comments

@jkloth
Copy link
Contributor

jkloth commented Mar 21, 2022

BPO 47089
Nosy @vstinner, @jkloth, @miss-islington
PRs
  • bpo-47089: Avoid test_compileall failures on Windows #32037
  • [3.10] bpo-47089: Avoid test_compileall failures on Windows (GH-32037) #32237
  • [3.9] bpo-47089: Avoid test_compileall failures on Windows (GH-32037). #32240
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2022-04-02.01:41:38.127>
    created_at = <Date 2022-03-21.21:34:06.347>
    labels = ['tests', '3.9', '3.10', '3.11']
    title = 'Avoid sporadic failure of test_compileall on Windows'
    updated_at = <Date 2022-04-02.21:56:55.927>
    user = 'https://github.com/jkloth'

    bugs.python.org fields:

    activity = <Date 2022-04-02.21:56:55.927>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2022-04-02.01:41:38.127>
    closer = 'vstinner'
    components = ['Tests']
    creation = <Date 2022-03-21.21:34:06.347>
    creator = 'jkloth'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 47089
    keywords = ['patch']
    message_count = 6.0
    messages = ['415711', '416504', '416519', '416527', '416528', '416597']
    nosy_count = 3.0
    nosy_names = ['vstinner', 'jkloth', 'miss-islington']
    pr_nums = ['32037', '32237', '32240']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue47089'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    @jkloth
    Copy link
    Contributor Author

    jkloth commented Mar 21, 2022

    Testing on Windows occasionally has issues in test_compileall when running with multiple processes. This is due to other test files importing stdlib modules at the same time that compileall is doing its own testing. While not fatal (test_compileall succeeds on re-run), the transient warnings obfuscate the test results for other "real" warnings (e.g., compiler warnings) without digging into each run separately.

    This can be avoided by using the PYTHONPYCACHEPREFIX functionality to compile the stdlib modules locally.

    @jkloth jkloth added 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir labels Mar 21, 2022
    @vstinner
    Copy link
    Member

    vstinner commented Apr 1, 2022

    New changeset 76b8a07 by Jeremy Kloth in branch 'main':
    bpo-47089: Avoid test_compileall failures on Windows (GH-32037)
    76b8a07

    @miss-islington
    Copy link
    Contributor

    New changeset 1069d52 by Miss Islington (bot) in branch '3.10':
    bpo-47089: Avoid test_compileall failures on Windows (GH-32037)
    1069d52

    @vstinner
    Copy link
    Member

    vstinner commented Apr 2, 2022

    New changeset 306a93b by Jeremy Kloth in branch '3.9':
    [3.9] bpo-47089: Avoid test_compileall failures on Windows (GH-32037). (GH-32240)
    306a93b

    @vstinner
    Copy link
    Member

    vstinner commented Apr 2, 2022

    Thanks for this enhancement. I close the issue.

    Do you know if it does fix the old bpo-37387 issue?

    @vstinner
    Copy link
    Member

    vstinner commented Apr 2, 2022

    bpo-37387 was closed as a duplicate of this issue.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants