-
-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-93858: Prevent error when activating venv in nested fish instances (GH-93931) #93931
Conversation
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
@vsajip do you have any comments for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really experienced in the fish shell, but I'll approve it since it appears reasonable.
hi, thanks for bugfix. could this solution be backported to older versions (and 3.11)?
|
I could work on this if there's interest from the maintainers. Just need some pointers on how to accomplish it. |
Only to 3.10 and later.
Thanks, but there's no real work to do here other than copy the script changes from this patch - if you're interested in contributing, I'd suggest working on something more worthwhile in terms of engagement. |
Thanks @thomasbbrunner for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Thanks @thomasbbrunner for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
GH-98402 is a backport of this pull request to the 3.11 branch. |
GH-98403 is a backport of this pull request to the 3.10 branch. |
…tances (pythonGH-93931) (cherry picked from commit 1172172) Co-authored-by: Thomas B. Brunner <thomasbbrunner@gmail.com>
…tances (pythonGH-93931) (cherry picked from commit 1172172) Co-authored-by: Thomas B. Brunner <thomasbbrunner@gmail.com>
Fixes #93858