Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mailbox: Remove deprecated support for text, only accept bytes #94350

Closed
vstinner opened this issue Jun 27, 2022 · 1 comment
Closed

mailbox: Remove deprecated support for text, only accept bytes #94350

vstinner opened this issue Jun 27, 2022 · 1 comment
Labels
type-bug An unexpected behavior, bug, or error

Comments

@vstinner
Copy link
Member

vstinner commented Jun 27, 2022 •
edited

In Python 3.2, the mailbox module was fixed to properly handle Unicode: it should now get bytes, rather than text. Support for accepting text was kept but marked as deprecated.

Main change: commit b7deff1 by @bitdancer in 2011: issue #53370.

In Python 3.12, 10 releases later, IMO it's now time to remove this legacy code.

I wrote PR #94351 to remove this code path.
@vstinner vstinner added the type-bug An unexpected behavior, bug, or error label Jun 27, 2022
@bedevere-bot bedevere-bot mentioned this issue Jun 27, 2022
Closed
@vstinner vstinner mentioned this issue Jun 28, 2022
Closed
@vstinner
Copy link
Member Author

vstinner commented Nov 4, 2022

I closed my PR: #94351 (comment)

@vstinner vstinner closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vstinner