Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95971: Turn @writes_bytecode_files to skip when not running #95972

Merged
merged 3 commits into from
Oct 15, 2022
Merged

gh-95971: Turn @writes_bytecode_files to skip when not running #95972

merged 3 commits into from
Oct 15, 2022

Conversation

youknowone
Copy link
Contributor

@youknowone youknowone commented Aug 13, 2022 •
edited

Before:

$ ./python.exe -B -m test test_importlib -v

(skipped)

----------------------------------------------------------------------
Ran 1411 tests in 1.979s

OK (skipped=20, expected failures=1)

After:

$ ./python.exe -B -m test test_importlib -v

(skipped)

----------------------------------------------------------------------
Ran 1411 tests in 2.103s

OK (skipped=91, expected failures=1)

Please check the skipped number is changed while actual test set is not changed.

youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 13, 2022
@youknowone
@writes_bytecode_files to skip
ed9d8e4 
python/cpython#95972
@youknowone youknowone mentioned this pull request Aug 13, 2022
Merged
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 13, 2022
@youknowone
@writes_bytecode_files to skip
ee6c62d 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 14, 2022
@youknowone
@writes_bytecode_files to skip
a19990c 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 14, 2022
@youknowone
@writes_bytecode_files to skip
76f02f6 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 15, 2022
@youknowone
@writes_bytecode_files to skip
cd54817 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 15, 2022
@youknowone
@writes_bytecode_files to skip
406616b 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 15, 2022
@youknowone
@writes_bytecode_files to skip
b5713f0 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 16, 2022
@youknowone
@writes_bytecode_files to skip
1ac9232 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 16, 2022
@youknowone
@writes_bytecode_files to skip
aebc978 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 16, 2022
@youknowone
@writes_bytecode_files to skip
a6d53f9 
python/cpython#95972
youknowone added a commit to youknowone/RustPython that referenced this pull request Aug 17, 2022
@youknowone
@writes_bytecode_files to skip
47dbafe 
python/cpython#95972
@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 7, 2022
@JelleZijlstra JelleZijlstra self-assigned this Oct 7, 2022
@JelleZijlstra JelleZijlstra merged commit 07b5c46 into python:main Oct 15, 2022
@miss-islington
Copy link
Contributor

Thanks @youknowone for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 15, 2022
@youknowone @miss-islington
pythongh-95971: Turn @writes_bytecode_files to skip when not running (p…
0b292a3 
…ythonGH-95972)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 07b5c46)

Co-authored-by: Jeong YunWon <69878+youknowone@users.noreply.github.com>
@bedevere-bot
Copy link

GH-98279 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 15, 2022
@bedevere-bot
Copy link

GH-98280 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 15, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 15, 2022
@youknowone @miss-islington
pythongh-95971: Turn @writes_bytecode_files to skip when not running (p…
c0e8679 
…ythonGH-95972)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 07b5c46)

Co-authored-by: Jeong YunWon <69878+youknowone@users.noreply.github.com>
@youknowone youknowone deleted the fix-writes-bytecode-files branch October 15, 2022 14:58
miss-islington added a commit that referenced this pull request Oct 15, 2022
@miss-islington @youknowone
gh-95971: Turn @writes_bytecode_files to skip when not running (GH-95972
4e78d94 
)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 07b5c46)

Co-authored-by: Jeong YunWon <69878+youknowone@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 15, 2022
@miss-islington @youknowone
gh-95971: Turn @writes_bytecode_files to skip when not running (GH-95972
146232f 
)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 07b5c46)

Co-authored-by: Jeong YunWon <69878+youknowone@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

Assignees

@JelleZijlstra JelleZijlstra

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@youknowone @miss-islington @bedevere-bot @JelleZijlstra @corona10