gh-98366: use sphinx.locale._ as gettext() in pyspecific.py #98437
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Misc/NEWS.d/next/Documentation/2022-10-19-07-15-52.gh-issue-98366.UskMXF.rst
Outdated
Show resolved
Hide resolved
|
May I please ping this, it's blocking |
@ezio-melotti, @merwok, @JulienPalard, @willingc You are enlisted on https://devguide.python.org/core-developers/experts/ as experts for documentation. Could you please review this PR? Thank you. |
mattwang44
force-pushed
the
fix-pyspecific-sphinx-locale-gettext
branch
from
f22bc2b
to
5775f51
Compare
…bility in pyspecific.py [why] spinix 5.3 changed locale.translators from a defaultdict(gettext.NullTranslations) to a dict, which leads to failure of pyspecific.py. Use sphinx.locale._ as gettext to fix the issue.
mattwang44
force-pushed
the
fix-pyspecific-sphinx-locale-gettext
branch
from
5775f51
to
383f9a7
Compare
|
Desk review looks reasonable, though ideally we'd confirm by building one of the translations against this PR. A |
@mattwang44, are you able to do that? |
|
@AA-Turner @AlexWaygood |
|
Great that the build passed. Is the translation correct for implementation detail directives, to sanity check that the new code works? A |
The static site of translated doc in zh_TW has been deployed to the GitHub page (GitHub Action logs is here). I've checked a couple of recently-merged translation PRs and it looks fine to me. |
|
Should this be backported to |
|
Yes! A |
AlexWaygood
added
needs backport to 3.10
|
Thanks @mattwang44 for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @mattwang44 for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
…thonGH-98437) fix(doc-tools): use sphinx.locale._ as gettext() for backward-compatibility in pyspecific.py [why] spinix 5.3 changed locale.translators from a defaultdict(gettext.NullTranslations) to a dict, which leads to failure of pyspecific.py. Use sphinx.locale._ as gettext to fix the issue. (cherry picked from commit d26ee8a) Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
|
GH-99358 is a backport of this pull request to the 3.10 branch. |
…thonGH-98437) fix(doc-tools): use sphinx.locale._ as gettext() for backward-compatibility in pyspecific.py [why] spinix 5.3 changed locale.translators from a defaultdict(gettext.NullTranslations) to a dict, which leads to failure of pyspecific.py. Use sphinx.locale._ as gettext to fix the issue. (cherry picked from commit d26ee8a) Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
|
GH-99359 is a backport of this pull request to the 3.11 branch. |
fix(doc-tools): use sphinx.locale._ as gettext() for backward-compatibility in pyspecific.py [why] spinix 5.3 changed locale.translators from a defaultdict(gettext.NullTranslations) to a dict, which leads to failure of pyspecific.py. Use sphinx.locale._ as gettext to fix the issue. (cherry picked from commit d26ee8a) Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
fix(doc-tools): use sphinx.locale._ as gettext() for backward-compatibility in pyspecific.py [why] spinix 5.3 changed locale.translators from a defaultdict(gettext.NullTranslations) to a dict, which leads to failure of pyspecific.py. Use sphinx.locale._ as gettext to fix the issue. (cherry picked from commit d26ee8a) Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
…thon#98437) fix(doc-tools): use sphinx.locale._ as gettext() for backward-compatibility in pyspecific.py [why] spinix 5.3 changed locale.translators from a defaultdict(gettext.NullTranslations) to a dict, which leads to failure of pyspecific.py. Use sphinx.locale._ as gettext to fix the issue.
sphinx 5.3 changed
sphinx.locale.translatorsfrom adefaultdict(gettext.NullTranslations)to adict(commit), which led to failure of pyspecific.py. Usesphinx.locale._asgettext()to fix the issue.