Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94808: cover PyMapping_HasKeyString and PyMapping_HasKey #98486

Merged
merged 1 commit into from
Oct 26, 2022
Merged

gh-94808: cover PyMapping_HasKeyString and PyMapping_HasKey #98486

merged 1 commit into from
Oct 26, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 20, 2022 •
edited by bedevere-bot

@sobolevn sobolevn added tests Tests in the Lib/test dir skip news labels Oct 20, 2022
JelleZijlstra
JelleZijlstra reviewed Oct 21, 2022
View reviewed changes
Modules/_testcapimodule.c
@@ -4690,6 +4690,40 @@ get_mapping_items(PyObject* self, PyObject *obj)
return PyMapping_Items(obj);
}

static PyObject *
test_mapping_has_key_string(PyObject *self, PyObject *Py_UNUSED(args))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to call this function from test_capi.py? Or is that automatic?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is:

cpython/Lib/test/test_capi.py

Lines 1185 to 1189 in 964a92c

class Test_testcapi(unittest.TestCase):
locals().update((name, getattr(_testcapi, name))
for name in dir(_testcapi)
if name.startswith('test_') and not name.endswith('_code'))

@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 26, 2022
@JelleZijlstra JelleZijlstra merged commit 5d30544 into python:main Oct 26, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-98698 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 26, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 26, 2022
@sobolevn @miss-islington
pythongh-94808: cover PyMapping_HasKeyString and PyMapping_HasKey (…
bc1a77e 
…pythonGH-98486)

(cherry picked from commit 5d30544)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-98699 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 26, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 26, 2022
@sobolevn @miss-islington
pythongh-94808: cover PyMapping_HasKeyString and PyMapping_HasKey (…
0ad6e12 
…pythonGH-98486)

(cherry picked from commit 5d30544)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Oct 26, 2022
@miss-islington @sobolevn
gh-94808: cover PyMapping_HasKeyString and PyMapping_HasKey (GH-9…
fd9bdde 
…8486)

(cherry picked from commit 5d30544)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Oct 26, 2022
@miss-islington @sobolevn
gh-94808: cover PyMapping_HasKeyString and PyMapping_HasKey (GH-9…
db14a9d 
…8486)

(cherry picked from commit 5d30544)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@mdboom mdboom mdboom approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sobolevn @miss-islington @bedevere-bot @mdboom @JelleZijlstra