Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99238: clarify the type of the env dict. #99253

Merged
merged 1 commit into from
Nov 8, 2022
Merged

gh-99238: clarify the type of the env dict. #99253

merged 1 commit into from
Nov 8, 2022

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Nov 8, 2022 •
edited by bedevere-bot

@gpshead gpshead added docs Documentation in the Doc dir needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 8, 2022
@gpshead gpshead self-assigned this Nov 8, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 8, 2022
Closed
@gpshead gpshead merged commit 2eee9d9 into python:main Nov 8, 2022
@miss-islington
Copy link
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@gpshead gpshead deleted the docs/env-subprocess branch November 8, 2022 21:00
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 8, 2022
@gpshead @miss-islington
pythongh-99238: clarify the type of the env dict. (pythonGH-99253)
892a6a0 
(cherry picked from commit 2eee9d9)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot
Copy link

GH-99263 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 8, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 8, 2022
@gpshead @miss-islington
pythongh-99238: clarify the type of the env dict. (pythonGH-99253)
1765ad2 
(cherry picked from commit 2eee9d9)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot
Copy link

GH-99264 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 8, 2022
miss-islington added a commit that referenced this pull request Nov 8, 2022
@miss-islington @gpshead
gh-99238: clarify the type of the env dict. (GH-99253)
bec1317 
(cherry picked from commit 2eee9d9)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington added a commit that referenced this pull request Nov 8, 2022
@miss-islington @gpshead
gh-99238: clarify the type of the env dict. (GH-99253)
00147a8 
(cherry picked from commit 2eee9d9)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gpshead gpshead

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not guarding env value in subprocess.py cause python crash when certain env variable is set to None
3 participants
@gpshead @miss-islington @bedevere-bot