Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importlib_metadata: define protocol for Distribution.metadata #263

Merged
merged 5 commits into from Dec 13, 2020

Conversation

FFY00
Copy link
Member

@FFY00 FFY00 commented Dec 1, 2020

Signed-off-by: Filipe Laíns lains@riseup.net

@FFY00
Copy link
Member Author

FFY00 commented Dec 1, 2020

Resolves #126.

Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Copy link
Member Author

FFY00 commented Dec 1, 2020

We run into the case here where we have different coverage in different versions, because of the backport import that will only run on older Python. The proper solution would be to run tests for both versions and merge the coverage, but since it is just an import, I added a # pragma: no cover there.

@FFY00
Copy link
Member Author

FFY00 commented Dec 1, 2020

Btw, relevant typeshed definitions: https://github.com/python/typeshed/blob/master/stdlib/3/email/message.pyi

@jaraco
Copy link
Member

jaraco commented Dec 13, 2020

This looks great. I'll add a changelog entry and get it out. Thanks!

@jaraco jaraco changed the base branch from master to main December 13, 2020 18:34
@jaraco
Copy link
Member

jaraco commented Dec 13, 2020

Well drat. I renamed the default branch from master to main and now diffcov is failing again as it was in #257, despite the fix still being applied. It seems the name 'master' is cached or hard-coded in diff-cover.

@jaraco
Copy link
Member

jaraco commented Dec 13, 2020

I'm going to proceed with manually merging and ignore the diff-cover failure for now. If the issue persists in new PRs, I'll probably just get rid of that footgun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants