Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting and handling PDM's symlinked packages #453

Merged
merged 12 commits into from Jun 18, 2023

Conversation

jherland
Copy link
Contributor

This is accompanying issue #452: The first commit adds a test case to demonstrate the issue, and the second attempt is a first, rough, attempt at fixing it.

I am unsure if a proper fix should only have _top_level_inferred() recurse/walk into symlinked directories, or if the recurse/walk should also apply to Distribution.files().

Commits:

  • Add test to demonstrate issue with symlinked packages
  • Attempt to fix issue with symlinked packages

@jaraco
Copy link
Member

jaraco commented Jun 18, 2023

I am unsure if a proper fix should only have _top_level_inferred() recurse/walk into symlinked directories, or if the recurse/walk should also apply to Distribution.files().

My instinct is that Distribution.files() should be naive and return the files for the virtual package as installed and not resolve to the linked content - at least until such a time that linked packages are more formally defined and accepted as a standard in the Python ecosystem.

@jaraco jaraco merged commit f604d3e into python:main Jun 18, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants