Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on zipfile.Path (where viable) #464

Closed
jaraco opened this issue Jul 7, 2023 · 1 comment
Closed

Rely on zipfile.Path (where viable) #464

jaraco opened this issue Jul 7, 2023 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@jaraco
Copy link
Member

jaraco commented Jul 7, 2023

When importlib_metadata was originally created, it supported Python 3.6 which didn't have zipfile.Path. Now importlib_metadata supports Python 3.8 and later, where zipfile.Path is available. However, that implementation may have deficiencies compared to later updates. Let's evaluate the state of zipfile.Path and zipp and ascertain a good breakpoint to prefer zipfile.Path.

@jaraco jaraco added the enhancement New feature or request label Jul 7, 2023
@jaraco
Copy link
Member Author

jaraco commented Jul 8, 2023

Reading back through the changelog, I notice that 3.12.0 adds a bugfix that's only backported to Python 3.10. But I also observe that bugfix is probably not pertinent to importlib_metadata.

It seems to me that 3.9.0 may be the latest change that's likely to impact users of importlib_metadata (if they were to try to pickle Distribution objects).

According to the README, that change was first included in Python 3.12, so no stable release of Python currently has that behavior.

Additionally, 3.4.0 added an important quality-of-life improvement to support multiple arguments to joinpath. That would have been made available in Python 3.11.

It hardly seems worth the effort to support both zipfile.Path and zipp.Path, at least at this stage.

@jaraco jaraco closed this as completed Jul 8, 2023
@jaraco jaraco added the wontfix This will not be worked on label Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant