-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
/
check-optional.test
615 lines (517 loc) · 16.4 KB
/
check-optional.test
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
-- Tests for strict Optional behavior
[case testImplicitNoneType]
x = None
x() # E: None not callable
[case testExplicitNoneType]
x = None # type: None
x() # E: None not callable
[case testNoneMemberOfOptional]
from typing import Optional
x = None # type: Optional[int]
[case testTypeMemberOfOptional]
from typing import Optional
x = 0 # type: Optional[int]
[case testNoneNotMemberOfType]
x = None # type: int
[out]
main:1: error: Incompatible types in assignment (expression has type None, variable has type "int")
[case testTypeNotMemberOfNone]
x = 0 # type: None
[out]
main:1: error: Incompatible types in assignment (expression has type "int", variable has type None)
[case testOptionalNotMemberOfType]
from typing import Optional
def f(a: int) -> None: pass
x = None # type: Optional[int]
f(x) # E: Argument 1 to "f" has incompatible type "Optional[int]"; expected "int"
[case testIsinstanceCases]
from typing import Optional
x = None # type: Optional[int]
if isinstance(x, int):
reveal_type(x) # E: Revealed type is 'builtins.int'
else:
reveal_type(x) # E: Revealed type is 'builtins.None'
[builtins fixtures/isinstance.pyi]
[case testIfCases]
from typing import Optional
x = None # type: Optional[int]
if x:
reveal_type(x) # E: Revealed type is 'builtins.int'
else:
reveal_type(x) # E: Revealed type is 'Union[builtins.int, builtins.None]'
[builtins fixtures/bool.pyi]
[case testIfNotCases]
from typing import Optional
x = None # type: Optional[int]
if not x:
reveal_type(x) # E: Revealed type is 'Union[builtins.int, builtins.None]'
else:
reveal_type(x) # E: Revealed type is 'builtins.int'
[builtins fixtures/bool.pyi]
[case testIsNotNoneCases]
from typing import Optional
x = None # type: Optional[int]
if x is not None:
reveal_type(x) # E: Revealed type is 'builtins.int'
else:
reveal_type(x) # E: Revealed type is 'builtins.None'
[builtins fixtures/bool.pyi]
[case testIsNoneCases]
from typing import Optional
x = None # type: Optional[int]
if x is None:
reveal_type(x) # E: Revealed type is 'builtins.None'
else:
reveal_type(x) # E: Revealed type is 'builtins.int'
reveal_type(x) # E: Revealed type is 'Union[builtins.int, builtins.None]'
[builtins fixtures/bool.pyi]
[case testAnyCanBeNone]
from typing import Optional, Any
x = None # type: Any
if x is None:
reveal_type(x) # E: Revealed type is 'builtins.None'
else:
reveal_type(x) # E: Revealed type is 'Any'
[builtins fixtures/bool.pyi]
[case testOrCases]
from typing import Optional
x = None # type: Optional[str]
y1 = x or 'a'
reveal_type(y1) # E: Revealed type is 'builtins.str'
y2 = x or 1
reveal_type(y2) # E: Revealed type is 'Union[builtins.str, builtins.int]'
z1 = 'a' or x
reveal_type(z1) # E: Revealed type is 'Union[builtins.str, builtins.None]'
z2 = int() or x
reveal_type(z2) # E: Revealed type is 'Union[builtins.int, builtins.str, builtins.None]'
[case testAndCases]
from typing import Optional
x = None # type: Optional[str]
y1 = x and 'b'
reveal_type(y1) # E: Revealed type is 'Union[builtins.str, builtins.None]'
y2 = x and 1 # x could be '', so...
reveal_type(y2) # E: Revealed type is 'Union[builtins.str, builtins.None, builtins.int]'
z1 = 'b' and x
reveal_type(z1) # E: Revealed type is 'Union[builtins.str, builtins.None]'
z2 = int() and x
reveal_type(z2) # E: Revealed type is 'Union[builtins.int, builtins.str, builtins.None]'
[case testLambdaReturningNone]
f = lambda: None
x = f() # E: Function does not return a value
[case testNoneArgumentType]
def f(x: None) -> None: pass
f(None)
[case testInferOptionalFromDefaultNone]
def f(x: int = None) -> None:
x + 1 # E: Unsupported left operand type for + (some union)
f(None)
[out]
[case testNoInferOptionalFromDefaultNone]
# flags: --no-implicit-optional
def f(x: int = None) -> None: # E: Incompatible types in assignment (expression has type None, variable has type "int")
pass
[out]
[case testInferOptionalFromDefaultNoneComment]
def f(x=None):
# type: (int) -> None
x + 1 # E: Unsupported left operand type for + (some union)
f(None)
[out]
[case testNoInferOptionalFromDefaultNoneComment]
# flags: --no-implicit-optional
def f(x=None): # E: Incompatible types in assignment (expression has type None, variable has type "int")
# type: (int) -> None
pass
[out]
[case testInferOptionalType]
x = None
if bool():
# scope limit assignment
x = 1
# in scope of the assignment, x is an int
reveal_type(x) # E: Revealed type is 'builtins.int'
# out of scope of the assignment, it's an Optional[int]
reveal_type(x) # E: Revealed type is 'Union[builtins.int, builtins.None]'
[builtins fixtures/bool.pyi]
[case testInferOptionalTypeLocallyBound]
x = None
x = 1
reveal_type(x) # E: Revealed type is 'builtins.int'
[case testInferOptionalAnyType]
from typing import Any
x = None
a = None # type: Any
if bool():
x = a
reveal_type(x) # E: Revealed type is 'Any'
reveal_type(x) # E: Revealed type is 'Union[Any, builtins.None]'
[builtins fixtures/bool.pyi]
[case testInferOptionalTypeFromOptional]
from typing import Optional
y = None # type: Optional[int]
x = None
x = y
reveal_type(x) # E: Revealed type is 'Union[builtins.int, builtins.None]'
[case testInferOptionalListType]
x = [None]
x.append(1) # E: Argument 1 to "append" of "list" has incompatible type "int"; expected None
[builtins fixtures/list.pyi]
[case testInferNonOptionalListType]
x = []
x.append(1)
x() # E: List[int] not callable
[builtins fixtures/list.pyi]
[case testInferOptionalDictKeyValueTypes]
x = {None: None}
x["bar"] = 1
[builtins fixtures/dict.pyi]
[out]
main:2: error: Invalid index type "str" for Dict[None, None]; expected type None
main:2: error: Incompatible types in assignment (expression has type "int", target has type None)
[case testInferNonOptionalDictType]
x = {}
x["bar"] = 1
x() # E: Dict[str, int] not callable
[builtins fixtures/dict.pyi]
[case testNoneClassVariable]
from typing import Optional
class C:
x = None # type: int
def __init__(self) -> None:
self.x = 0
[case testNoneClassVariableInInit]
from typing import Optional
class C:
x = None # type: int
def __init__(self) -> None:
self.x = None # E: Incompatible types in assignment (expression has type None, variable has type "int")
[out]
[case testMultipleAssignmentNoneClassVariableInInit]
from typing import Optional
class C:
x, y = None, None # type: int, str
def __init__(self) -> None:
self.x = None # E: Incompatible types in assignment (expression has type None, variable has type "int")
self.y = None # E: Incompatible types in assignment (expression has type None, variable has type "str")
[out]
[case testOverloadWithNone]
from foo import *
[file foo.pyi]
from typing import overload
@overload
def f(x: None) -> str: pass
@overload
def f(x: int) -> int: pass
reveal_type(f(None)) # E: Revealed type is 'builtins.str'
reveal_type(f(0)) # E: Revealed type is 'builtins.int'
[case testOptionalTypeOrTypePlain]
from typing import Optional
def f(a: Optional[int]) -> int:
return a or 0
[out]
[case testOptionalTypeOrTypeTypeVar]
from typing import Optional, TypeVar
T = TypeVar('T')
def f(a: Optional[T], b: T) -> T:
return a or b
[out]
[case testOptionalTypeOrTypeBothOptional]
from typing import Optional
def f(a: Optional[int], b: Optional[int]) -> None:
reveal_type(a or b)
def g(a: int, b: Optional[int]) -> None:
reveal_type(a or b)
[out]
main:3: error: Revealed type is 'Union[builtins.int, builtins.None]'
main:5: error: Revealed type is 'Union[builtins.int, builtins.None]'
[case testOptionalTypeOrTypeComplexUnion]
from typing import Union
def f(a: Union[int, str, None]) -> None:
reveal_type(a or 'default')
[out]
main:3: error: Revealed type is 'Union[builtins.int, builtins.str]'
[case testOptionalTypeOrTypeNoTriggerPlain]
from typing import Optional
def f(a: Optional[int], b: int) -> int:
return b or a
[out]
main:3: error: Incompatible return value type (got "Optional[int]", expected "int")
[case testOptionalTypeOrTypeNoTriggerTypeVar]
from typing import Optional, TypeVar
T = TypeVar('T')
def f(a: Optional[T], b: T) -> T:
return b or a
[out]
main:4: error: Incompatible return value type (got "Optional[T]", expected "T")
[case testNoneOrStringIsString]
def f() -> str:
a = None
b = ''
return a or b
[out]
[case testNoneOrTypeVarIsTypeVar]
from typing import TypeVar
T = TypeVar('T')
def f(b: T) -> T:
a = None
return a or b
[out]
[case testYieldNothingInFunctionReturningGenerator]
from typing import Generator
def f() -> Generator[None, None, None]:
yield
[out]
[case testNoneAndStringIsNone]
a = None
b = "foo"
reveal_type(a and b) # E: Revealed type is 'builtins.None'
[case testNoneMatchesObjectInOverload]
import a
a.f(None)
[file a.pyi]
from typing import overload
@overload
def f() -> None: ...
@overload
def f(o: object) -> None: ...
[case testGenericSubclassReturningNone]
from typing import Generic, TypeVar
T = TypeVar('T')
class Base(Generic[T]):
def f(self) -> T:
pass
class SubNone(Base[None]):
def f(self) -> None:
pass
class SubInt(Base[int]):
def f(self) -> int:
return 1
[case testUseOfNoneReturningFunction]
from typing import Optional
def f() -> None:
pass
def g(x: Optional[int]) -> int:
pass
x = f() # E: "f" does not return a value
f() + 1 # E: "f" does not return a value
g(f()) # E: "f" does not return a value
[case testEmptyReturn]
def f() -> None:
return
[case testReturnNone]
def f() -> None:
return None
[case testNoneCallable]
from typing import Callable
def f() -> None: pass
x = f # type: Callable[[], None]
[case testOptionalCallable]
from typing import Callable, Optional
T = Optional[Callable[..., None]]
[case testAnyTypeInPartialTypeList]
# flags: --check-untyped-defs
def f(): ...
def lookup_field(name, obj):
try:
pass
except:
attr = f()
else:
attr = None
[case testTernaryWithNone]
reveal_type(None if bool() else 0) # E: Revealed type is 'Union[builtins.int, builtins.None]'
[builtins fixtures/bool.pyi]
[case testListWithNone]
reveal_type([0, None, 0]) # E: Revealed type is 'builtins.list[Union[builtins.int, builtins.None]]'
[builtins fixtures/list.pyi]
[case testOptionalWhitelistSuppressesOptionalErrors]
# flags: --strict-optional-whitelist
import a
import b
[file a.py]
from typing import Optional
x = None # type: Optional[str]
x + "foo"
[file b.py]
from typing import Optional
x = None # type: Optional[int]
x + 1
[case testOptionalWhitelistPermitsOtherErrors]
# flags: --strict-optional-whitelist
import a
import b
[file a.py]
from typing import Optional
x = None # type: Optional[str]
x + "foo"
[file b.py]
from typing import Optional
x = None # type: Optional[int]
x + 1
1 + "foo"
[out]
tmp/b.py:4: error: Unsupported operand types for + ("int" and "str")
[case testOptionalWhitelistPermitsWhitelistedFiles]
# flags: --strict-optional-whitelist **/a.py
import a
import b
[file a.py]
from typing import Optional
x = None # type: Optional[str]
x + "foo"
[file b.py]
from typing import Optional
x = None # type: Optional[int]
x + 1
[out]
tmp/a.py:3: error: Unsupported left operand type for + (some union)
[case testNoneContextInference]
from typing import Dict, List
def f() -> List[None]:
return []
def g() -> Dict[None, None]:
return {}
[builtins fixtures/dict.pyi]
[case testRaiseFromNone]
raise BaseException from None
[builtins fixtures/exception.pyi]
[case testOptionalNonPartialTypeWithNone]
from typing import Generator
def f() -> Generator[str, None, None]: pass
x = f()
reveal_type(x) # E: Revealed type is 'typing.Generator[builtins.str, builtins.None, builtins.None]'
l = [f()]
reveal_type(l) # E: Revealed type is 'builtins.list[typing.Generator*[builtins.str, builtins.None, builtins.None]]'
[builtins fixtures/list.pyi]
[case testNoneListTernary]
x = [None] if "" else [1] # E: List item 0 has incompatible type "int"; expected None
[builtins fixtures/list.pyi]
[case testListIncompatibleErrorMessage]
from typing import List, Callable
def foo(l: List[Callable[[], str]]) -> None: pass
def f() -> int:
return 42
foo([f]) # E: List item 0 has incompatible type Callable[[], int]; expected Callable[[], str]
[builtins fixtures/list.pyi]
[case testInferEqualsNotOptional]
from typing import Optional
x = '' # type: Optional[str]
if x == '<string>':
reveal_type(x) # E: Revealed type is 'builtins.str'
else:
reveal_type(x) # E: Revealed type is 'Union[builtins.str, builtins.None]'
[builtins fixtures/ops.pyi]
[case testInferEqualsNotOptionalWithUnion]
from typing import Union
x = '' # type: Union[str, int, None]
if x == '<string>':
reveal_type(x) # E: Revealed type is 'Union[builtins.str, builtins.int]'
else:
reveal_type(x) # E: Revealed type is 'Union[builtins.str, builtins.int, builtins.None]'
[builtins fixtures/ops.pyi]
[case testInferEqualsNotOptionalWithOverlap]
from typing import Union
x = '' # type: Union[str, int, None]
if x == object():
reveal_type(x) # E: Revealed type is 'Union[builtins.str, builtins.int]'
else:
reveal_type(x) # E: Revealed type is 'Union[builtins.str, builtins.int, builtins.None]'
[builtins fixtures/ops.pyi]
[case testInferEqualsStillOptionalWithNoOverlap]
from typing import Optional
x = '' # type: Optional[str]
if x == 0:
reveal_type(x) # E: Revealed type is 'Union[builtins.str, builtins.None]'
else:
reveal_type(x) # E: Revealed type is 'Union[builtins.str, builtins.None]'
[builtins fixtures/ops.pyi]
[case testInferEqualsStillOptionalWithBothOptional]
from typing import Union
x = '' # type: Union[str, int, None]
y = '' # type: Union[str, None]
if x == y:
reveal_type(x) # E: Revealed type is 'Union[builtins.str, builtins.int, builtins.None]'
else:
reveal_type(x) # E: Revealed type is 'Union[builtins.str, builtins.int, builtins.None]'
[builtins fixtures/ops.pyi]
[case testWarnNoReturnWorksWithStrictOptional]
# flags: --warn-no-return
def f() -> None:
1 + 1 # no error
def g() -> int:
1 + 1 #
[out]
main:5: error: Missing return statement
[case testGenericTypeAliasesOptional]
from typing import TypeVar, Generic, Optional
T = TypeVar('T')
class Node(Generic[T]):
def __init__(self, x: T) -> None:
self.x = x
ONode = Optional[Node[T]]
def f(x: T) -> ONode[T]:
if 1 > 0:
return Node(x)
else:
return None
x = None # type: ONode[int]
x = f(1)
x = f('x') # E: Argument 1 to "f" has incompatible type "str"; expected "int"
x.x = 1 # E: Item "None" of "Optional[Node[int]]" has no attribute "x"
if x is not None:
x.x = 1 # OK here
[builtins fixtures/ops.pyi]
[case testOptionalLambdaInference]
from typing import Optional, Callable
f = None # type: Optional[Callable[[int], None]]
f = lambda x: None
f(0)
[builtins fixtures/function.pyi]
[case testDontSimplifyNoneUnionsWithStrictOptional]
from typing import Any, TypeVar, Union
A = None # type: Any
class C(A): pass
T = TypeVar('T')
S = TypeVar('S')
def u(x: T, y: S) -> Union[S, T]: pass
a = None # type: Any
# Test both orders
reveal_type(u(C(), None)) # E: Revealed type is 'Union[builtins.None, __main__.C*]'
reveal_type(u(None, C())) # E: Revealed type is 'Union[__main__.C*, builtins.None]'
reveal_type(u(a, None)) # E: Revealed type is 'Union[builtins.None, Any]'
reveal_type(u(None, a)) # E: Revealed type is 'Union[Any, builtins.None]'
reveal_type(u(1, None)) # E: Revealed type is 'Union[builtins.None, builtins.int*]'
reveal_type(u(None, 1)) # E: Revealed type is 'Union[builtins.int*, builtins.None]'
[case testOptionalAndAnyBaseClass]
from typing import Any, Optional
A = None # type: Any
class C(A):
pass
x = None # type: Optional[C]
x.foo() # E: Item "None" of "Optional[C]" has no attribute "foo"
[case testIsinstanceAndOptionalAndAnyBase]
from typing import Any, Optional
B = None # type: Any
class A(B): pass
def f(a: Optional[A]):
reveal_type(a) # E: Revealed type is 'Union[__main__.A, builtins.None]'
if a is not None:
reveal_type(a) # E: Revealed type is '__main__.A'
else:
reveal_type(a) # E: Revealed type is 'builtins.None'
reveal_type(a) # E: Revealed type is 'Union[__main__.A, builtins.None]'
[builtins fixtures/isinstance.pyi]
[case testFlattenOptionalUnion]
from typing import Optional, Union
x: Optional[Union[int, str]]
reveal_type(x) # E: Revealed type is 'Union[builtins.int, builtins.str, builtins.None]'
y: Optional[Union[int, None]]
reveal_type(y) # E: Revealed type is 'Union[builtins.int, builtins.None]'
[case testUnionTruthinessTracking]
from typing import Optional, Any
def test_or_shortcut(value: Optional[Any]) -> None:
if not value:
pass
if not value or value.get('foo') == 'hello':
pass
[builtins fixtures/bool.pyi]