You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, comments can be added to a line to ignore either all errors (# type: ignore), or a specific error code (eg. # type: ignore[call-arg]). When a single statement spans multiple lines, the comment has to be added on the line that mypy "decides" is the one with the error (is it the first line of the expression, rather than first line of the statement?). In some cases, it would make sense to allow the comment to be on a different line of the same statement. I propose allowing it to be on any line of the statement, and therefore to apply to the whole statement.
Pitch
Sometimes it makes more sense for it to be another line, such as when importing something that mypy thinks does not exist, it makes sense to have the ignore on the same line as the attribute that is reported as not existing.
from typing import ( # ignore currently needs to be here
Union,
DoesNotExist, # type: ignore[error attr-defined]
)
Sometimes, a formatter like black changes a long line into a multiple line statement. The comment that was at the end of the line is moved to the end of the last line.
def foo(bar:int) -> str: ...
def baz() -> int: ...
a = ( # type: ignore[call-arg]
"something"
if baz() > 0 else
foo() # ignore currently needs to be here
) # formatters (eg. black) often put ignore here
i agree with the first example because you should be able to split an expression up such that the part with the error is isolated on a single line, to minimize the chance of the type:ignore comment effecting other parts of the expression too
in the second example i think it's preferable for it to require the type:ignore comment to be on the line with the error, because otherwise it's easy to accidentally insert a new error and ignore it:
deffoo(bar:int) ->str: ...
defbaz(bar: int) ->int: ... # new change, `baz` now requires an arga= ( # type: ignore[call-arg]"something"ifbaz() >0elsefoo()
) # formatters (eg. black) often put ignore here
if it allowed the comment on any line in the statement, now we get no new error. the type:ignore that was intended to only suppress the error on foo now also suppresses the new error as well
Feature
Currently, comments can be added to a line to ignore either all errors (
# type: ignore
), or a specific error code (eg.# type: ignore[call-arg]
). When a single statement spans multiple lines, the comment has to be added on the line that mypy "decides" is the one with the error (is it the first line of the expression, rather than first line of the statement?). In some cases, it would make sense to allow the comment to be on a different line of the same statement. I propose allowing it to be on any line of the statement, and therefore to apply to the whole statement.Pitch
Sometimes it makes more sense for it to be another line, such as when importing something that mypy thinks does not exist, it makes sense to have the ignore on the same line as the attribute that is reported as not existing.
Sometimes, a formatter like black changes a long line into a multiple line statement. The comment that was at the end of the line is moved to the end of the last line.
https://mypy-play.net/?mypy=latest&python=3.10&flags=show-error-codes%2Cstrict%2Cwarn-unused-ignores&gist=e41c530d401ac4f21cb7a21e68fea141
The text was updated successfully, but these errors were encountered: