Support calling dict() with positional arguments and keyword arguments or **kwargs #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still cases like this are broken: class D(Dict[S, T], Generic[T, S]): ... Also, we don't catch all invalid uses of keyword arguments with dict subclasses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also inherit special signature of
dict. Some special cases (that are likely very rare) are not handled well. I'll create a separate issue for those. The implementation is a hack but it mostly does the right thing and is fairly simple, and a clean solution would be much more complicated (for example, a plugin system or constraint based type inference system for function signatures), so I think this is okay for now.