Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.8 planning #16602

Closed
5 of 6 tasks
wesleywright opened this issue Dec 1, 2023 · 15 comments
Closed
5 of 6 tasks

Release 1.8 planning #16602

wesleywright opened this issue Dec 1, 2023 · 15 comments
Assignees
Labels
meta Issues tracking a broad area of work

Comments

@wesleywright
Copy link
Collaborator

wesleywright commented Dec 1, 2023

I'm planning to make a 1.8 release sometime around Dec 15.

Please post here any issues you'd like to see fixed in the release, or PRs you'd like to have merged. I'll cut the release branch around early next week.

Tasks

@wesleywright wesleywright self-assigned this Dec 1, 2023
@wesleywright wesleywright added meta Issues tracking a broad area of work and removed feature labels Dec 1, 2023
@AlexWaygood
Copy link
Member

AlexWaygood commented Dec 3, 2023

Sounds great! Here's a few PRs that might be worth considering:

@AlexWaygood
Copy link
Member

AlexWaygood commented Dec 3, 2023

There's a few more outstanding issues reporting regressions in mypy 1.7 that are worth noting, but I don't think any of them have PRs linked to them yet. I personally wouldn't hold up the 1.8 release for any of them:

@hauntsaninja
Copy link
Collaborator

I'd like to see #16608 merged

@wesleywright
Copy link
Collaborator Author

I've cut a release-1.8 branch for this release. It's based on the latest master commit (7c33e7c) so it should already contain #16504, #16330, and #16513.

@wesleywright
Copy link
Collaborator Author

cherry-picked #16608 onto release-1.8

@wesleywright
Copy link
Collaborator Author

cherry-picked #16541. hopefully #16524 lands in the next couple of days.

@AlexWaygood
Copy link
Member

AlexWaygood commented Dec 12, 2023

Looks like our CI is broken on master (https://github.com/python/mypy/actions/runs/7186189373/job/19571043378), apparently because of pypa/hatch#1113. (We simulate various typed packages as part of our tests; they all use hatchling as their backend.)

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Dec 12, 2023

Thanks, #16655 to fix that. (We switched to hatchling because setuptools editable installs no longer work well with type checkers)

@hauntsaninja
Copy link
Collaborator

I'd also say we shouldn't block 1.8 on #16524. I can make a point release for it whenever its merged.

@wesleywright
Copy link
Collaborator Author

Cherry-picked #16655. I'll likely finish out the release in the next couple of days; I'll cherry-pick #16524 if it lands before then, otherwise I'll just move forward.

@cdce8p
Copy link
Collaborator

cdce8p commented Dec 15, 2023

It might be a bit late but the last typeshed update #16665 includes some useful improvements for asyncio functions with callbacks. Those are among the first uses of TypeVarTuples in typeshed.

@wesleywright
Copy link
Collaborator Author

1.8 release blogpost: https://mypy-lang.blogspot.com/2023/12/mypy-18-released.html

@intgr
Copy link
Contributor

intgr commented Dec 26, 2023

@ymyzk Can you please add mypy 1.8.0 to mypy-play.net?

@ymyzk
Copy link

ymyzk commented Dec 26, 2023

@intgr Thanks for the reminder. Yes, I just added mypy 1.8.0: https://mypy-play.net/?mypy=1.8.0&python=3.12&flags=version

@meshy
Copy link
Contributor

meshy commented Jan 30, 2024

Should this issue be closed now that 1.8 has been released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues tracking a broad area of work
Projects
None yet
Development

No branches or pull requests

7 participants