Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.540 planning #4084

Closed
JukkaL opened this issue Oct 9, 2017 · 13 comments
Closed

Release 0.540 planning #4084

JukkaL opened this issue Oct 9, 2017 · 13 comments

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 9, 2017

We are going to switch to more frequent mypy releases. Our new target is ~3 weeks between releases. (Vacations, travel and other distractions will cause the actual time between releases vary.)

Timeline for the next release:

  • I'll cut the release branch on Friday, October 13.
  • The tentative release date is Wednesday, October 18.

Please add to this issue PRs and fixes that you think need to be included in the release, but please be reasonable. If there's no PR yet we likely won't have time to finish the review by Friday -- but on a more positive note, the next release after 0.540 won't be too far away!

@ilevkivskyi
Copy link
Member

Among my PRs:

Plus (strict-)optionally:

@ilevkivskyi
Copy link
Member

On a second thought last two are probably too tight for Friday, let's focus on other five.

@JelleZijlstra
Copy link
Member

It would be nice to have some form of #4076 in, since it fixes a nasty bug in config file parsing (even mypy's own config was affected).

@gvanrossum
Copy link
Member

I am hoping to come up with a decision about the lxml stubs -- can we fix them, should we remove them (they can be revived as a separate project once @ethanhs's PEP 561 is implemented). @JelleZijlstra do you have a strong opinion here?

@JelleZijlstra
Copy link
Member

Don't feel strongly about it. Maybe waiting for PEP 561 makes sense.

@elazarg
Copy link
Contributor

elazarg commented Oct 10, 2017

#4016 (correct subtype check for self argument in an attribute/property access)

@gvanrossum
Copy link
Member

Could a fix for #4097 be included? It seems to be a regression that appeared in 0.530.

@ilevkivskyi
Copy link
Member

@gvanrossum

Could a fix for #4097 be included? It seems to be a regression that appeared in 0.530.

I am working on it now. If everything goes well (i.e. if I will have more time today), then I will make a PR by the end of the day.

@JukkaL
Copy link
Collaborator Author

JukkaL commented Oct 13, 2017

Could a fix for #4097 be included? It seems to be a regression that appeared in 0.530.

Yes, unless it's particularly risky. Fixes to regressions may be cherry picked even after the release branch has been cut.

@gvanrossum
Copy link
Member

I've cut the release branch: https://github.com/python/mypy/tree/release-0.540. We can cherry-pick the fix for #4097 if it's ready and deemed safe.

Of the suggested PRs, these didn't make it in and I don't expect them to be cp'ed:

There will be another release about three weeks later.

@ilevkivskyi
Copy link
Member

Whether #4070 gets in the release or not, I would prefer it reviewed and merged in master soon, since it is prone to merge conflicts.

@gvanrossum
Copy link
Member

I just talked to Jukka and we're going to do the release tomorrow from what's currently in the release-0.540 branch (also current master).

@JukkaL
Copy link
Collaborator Author

JukkaL commented Oct 18, 2017

The new release date is Friday instead of Wednesday to give it more time to be tested internally at Dropbox. I'm not expecting any additional changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants