New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.540 planning #4084

Closed
JukkaL opened this Issue Oct 9, 2017 · 13 comments

Comments

Projects
None yet
5 participants
@JukkaL
Collaborator

JukkaL commented Oct 9, 2017

We are going to switch to more frequent mypy releases. Our new target is ~3 weeks between releases. (Vacations, travel and other distractions will cause the actual time between releases vary.)

Timeline for the next release:

  • I'll cut the release branch on Friday, October 13.
  • The tentative release date is Wednesday, October 18.

Please add to this issue PRs and fixes that you think need to be included in the release, but please be reasonable. If there's no PR yet we likely won't have time to finish the review by Friday -- but on a more positive note, the next release after 0.540 won't be too far away!

@ilevkivskyi

This comment has been minimized.

Show comment
Hide comment
@ilevkivskyi

ilevkivskyi Oct 9, 2017

Collaborator

Among my PRs:

  • #4000 (simplifies/unifies rules for type aliases)
  • #4038 (fixes metaclass attribute lookup and corresponding --incremental crash)
  • #4059 (check code after inferred UninhabitedType, this fixes several potential false negatives)
  • #4067 (multiassign from union, an oldest high priority issue plus a bonus crash)
  • #4073 (a recent regression)

Plus (strict-)optionally:

  • #4070 (depends on #4072) it fixes no issues, so probably is not urgent, but nice to have.
Collaborator

ilevkivskyi commented Oct 9, 2017

Among my PRs:

  • #4000 (simplifies/unifies rules for type aliases)
  • #4038 (fixes metaclass attribute lookup and corresponding --incremental crash)
  • #4059 (check code after inferred UninhabitedType, this fixes several potential false negatives)
  • #4067 (multiassign from union, an oldest high priority issue plus a bonus crash)
  • #4073 (a recent regression)

Plus (strict-)optionally:

  • #4070 (depends on #4072) it fixes no issues, so probably is not urgent, but nice to have.
@ilevkivskyi

This comment has been minimized.

Show comment
Hide comment
@ilevkivskyi

ilevkivskyi Oct 9, 2017

Collaborator

On a second thought last two are probably too tight for Friday, let's focus on other five.

Collaborator

ilevkivskyi commented Oct 9, 2017

On a second thought last two are probably too tight for Friday, let's focus on other five.

@JelleZijlstra

This comment has been minimized.

Show comment
Hide comment
@JelleZijlstra

JelleZijlstra Oct 9, 2017

Collaborator

It would be nice to have some form of #4076 in, since it fixes a nasty bug in config file parsing (even mypy's own config was affected).

Collaborator

JelleZijlstra commented Oct 9, 2017

It would be nice to have some form of #4076 in, since it fixes a nasty bug in config file parsing (even mypy's own config was affected).

@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Oct 9, 2017

Member

I am hoping to come up with a decision about the lxml stubs -- can we fix them, should we remove them (they can be revived as a separate project once @ethanhs's PEP 561 is implemented). @JelleZijlstra do you have a strong opinion here?

Member

gvanrossum commented Oct 9, 2017

I am hoping to come up with a decision about the lxml stubs -- can we fix them, should we remove them (they can be revived as a separate project once @ethanhs's PEP 561 is implemented). @JelleZijlstra do you have a strong opinion here?

@JelleZijlstra

This comment has been minimized.

Show comment
Hide comment
@JelleZijlstra

JelleZijlstra Oct 9, 2017

Collaborator

Don't feel strongly about it. Maybe waiting for PEP 561 makes sense.

Collaborator

JelleZijlstra commented Oct 9, 2017

Don't feel strongly about it. Maybe waiting for PEP 561 makes sense.

@elazarg

This comment has been minimized.

Show comment
Hide comment
@elazarg

elazarg Oct 10, 2017

Contributor

#4016 (correct subtype check for self argument in an attribute/property access)

Contributor

elazarg commented Oct 10, 2017

#4016 (correct subtype check for self argument in an attribute/property access)

@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Oct 13, 2017

Member

Could a fix for #4097 be included? It seems to be a regression that appeared in 0.530.

Member

gvanrossum commented Oct 13, 2017

Could a fix for #4097 be included? It seems to be a regression that appeared in 0.530.

@ilevkivskyi

This comment has been minimized.

Show comment
Hide comment
@ilevkivskyi

ilevkivskyi Oct 13, 2017

Collaborator

@gvanrossum

Could a fix for #4097 be included? It seems to be a regression that appeared in 0.530.

I am working on it now. If everything goes well (i.e. if I will have more time today), then I will make a PR by the end of the day.

Collaborator

ilevkivskyi commented Oct 13, 2017

@gvanrossum

Could a fix for #4097 be included? It seems to be a regression that appeared in 0.530.

I am working on it now. If everything goes well (i.e. if I will have more time today), then I will make a PR by the end of the day.

@JukkaL

This comment has been minimized.

Show comment
Hide comment
@JukkaL

JukkaL Oct 13, 2017

Collaborator

Could a fix for #4097 be included? It seems to be a regression that appeared in 0.530.

Yes, unless it's particularly risky. Fixes to regressions may be cherry picked even after the release branch has been cut.

Collaborator

JukkaL commented Oct 13, 2017

Could a fix for #4097 be included? It seems to be a regression that appeared in 0.530.

Yes, unless it's particularly risky. Fixes to regressions may be cherry picked even after the release branch has been cut.

@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Oct 13, 2017

Member

I've cut the release branch: https://github.com/python/mypy/tree/release-0.540. We can cherry-pick the fix for #4097 if it's ready and deemed safe.

Of the suggested PRs, these didn't make it in and I don't expect them to be cp'ed:

There will be another release about three weeks later.

Member

gvanrossum commented Oct 13, 2017

I've cut the release branch: https://github.com/python/mypy/tree/release-0.540. We can cherry-pick the fix for #4097 if it's ready and deemed safe.

Of the suggested PRs, these didn't make it in and I don't expect them to be cp'ed:

There will be another release about three weeks later.

@ilevkivskyi

This comment has been minimized.

Show comment
Hide comment
@ilevkivskyi

ilevkivskyi Oct 13, 2017

Collaborator

Whether #4070 gets in the release or not, I would prefer it reviewed and merged in master soon, since it is prone to merge conflicts.

Collaborator

ilevkivskyi commented Oct 13, 2017

Whether #4070 gets in the release or not, I would prefer it reviewed and merged in master soon, since it is prone to merge conflicts.

@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Oct 17, 2017

Member

I just talked to Jukka and we're going to do the release tomorrow from what's currently in the release-0.540 branch (also current master).

Member

gvanrossum commented Oct 17, 2017

I just talked to Jukka and we're going to do the release tomorrow from what's currently in the release-0.540 branch (also current master).

@JukkaL

This comment has been minimized.

Show comment
Hide comment
@JukkaL

JukkaL Oct 18, 2017

Collaborator

The new release date is Friday instead of Wednesday to give it more time to be tested internally at Dropbox. I'm not expecting any additional changes.

Collaborator

JukkaL commented Oct 18, 2017

The new release date is Friday instead of Wednesday to give it more time to be tested internally at Dropbox. I'm not expecting any additional changes.

@gvanrossum gvanrossum closed this Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment