Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Invalid base class" when inheriting from tuple of classes #5928

Open
PeterJCLaw opened this issue Nov 20, 2018 · 2 comments
Open

"Invalid base class" when inheriting from tuple of classes #5928

PeterJCLaw opened this issue Nov 20, 2018 · 2 comments
Labels

Comments

@PeterJCLaw
Copy link
Contributor

I appreciate there are some complexities around handling inheritance from dynamic sources, so it's possible that this is a duplicate of one of those (#4284 seems most likely related), though I think this is a slightly different case.

I would like the following to pass type checking, yet I get an "Invalid base class" error even after adding an explicit type annotation.

Because in this case the tuple is of a fixed size (and the members of the tuple are all valid types) it feels like it should be possible to determine that it's valid to inherit from an expansion of that tuple.

# foo.py
from typing import Tuple, Type

class A: pass
class B: pass

PlainBases = (A, B)
reveal_type(PlainBases)
# ^ Revealed type is 'Tuple[def () -> foo.A, def () -> foo.B]'

class PlainC(*PlainBases):
# ^ Invalid base class
    pass

AnotatedBases = (A, B)  # type: Tuple[Type[A], Type[B]]
reveal_type(AnotatedBases)
# ^ Revealed type is 'Tuple[Type[foo.A], Type[foo.B]]'

class AnotatedC(*AnotatedBases):
# ^ Invalid base class
    pass

I'm using Python 3.5 and mypy 0.620. Having just updated to 0.641 I see that there are now also errors that "Can use starred expression only as assignment target" in the above, which goes some way to explaining why this is currently unsupported, though leads to another one (apologies if this is documented somewhere):
Why is it that mypy is unable to expand the types of this starred expression?

Is this a result of the issue relating to multiple passes which is mentioned in #4284 (comment) or something else?

Is this something which is possible/likely to be supported?

@ilevkivskyi
Copy link
Member

Currently we already have three other issues about dynamic base classes, but I am not sure which should be closed because all them have some discussion and some examples.

As another random idea we can potentially support this is the base class tuple is declared as Final.

@ilevkivskyi
Copy link
Member

For the reference other issues are:
#3587
#2477
#2813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants