Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.800 planning #9926

Closed
ilevkivskyi opened this issue Jan 18, 2021 · 10 comments
Closed

Release 0.800 planning #9926

ilevkivskyi opened this issue Jan 18, 2021 · 10 comments

Comments

@ilevkivskyi
Copy link
Member

I am going to release mypy 0.800 soon, most likely on Tuesday, January 26. The release branch will be based at 28f92ac. If anyone needs to cherry-pick anything there, please list the PRs here. Also please list any important issues you think are release blockers.

cc @JukkaL

@ilevkivskyi
Copy link
Member Author

Hm, this is weird, Travis build failed on the release branch https://travis-ci.com/github/python/mypy/jobs/472767092, although it passed on the same commit in master. @JukkaL did this happen before?

@gvanrossum
Copy link
Member

Could you add #9865?

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Jan 18, 2021

The release branch commit you've chosen is from just before the new wheel building process was merged (#9536), so you're out of sync with https://github.com/mypyc/mypy_mypyc-wheels, hence build failure. (And feel free to tag me if you run into other wheel building issues / release script issues).

I recommend using 0996c42 as the release branch commit. It's just one day / a couple commits past 28f92ac, but contains several other commits that the release should have: #9763 (important documentation), #9570 (wheel building), #9886 (wheel building), #9887 (3.9 support), #9889 (fixes a crash that's been reported multiple times).

Finally, could you also review and cherry pick #9923? I think this is a release blocker. The PR documents the new source finding behaviour which is likely to be one of the most salient things people run into when upgrading to the new version. (mypy will likely start type checking a lot more files and many people will realise they want to pass --namespace-packages).

@ilevkivskyi
Copy link
Member Author

Could you add #9865?

@JukkaL do you think it is stable enough to include this? I would prefer to wait few weeks before releasing this.

I recommend using 0996c42 as the release branch commit.

OK, this makes sense.

Finally, could you also review and cherry pick #9923? I think this is a release blocker.

This is a purely documentation PR so doesn't look critical, and ReadTheDocs is built from master IIUC (unless this was changed again). But anyway, I will definitely CP it if someone reviews and merges it.

@ilevkivskyi
Copy link
Member Author

I recommend using 0996c42 as the release branch commit.

@hauntsaninja Oh wait, you forgot to mention something, this commit is on different typeshed pin. I don't want to include this as it is not tested internally, so will instead just CP the wheels build change and the 3.9 support classifier.

@ilevkivskyi
Copy link
Member Author

Now the AppVeyor build failed https://ci.appveyor.com/project/mypyc/mypy-mypyc-wheels/builds/37333052, but IIUC we don't need it anymore because Windows wheels are built by Github Actions.

@ilevkivskyi
Copy link
Member Author

OK, I cherry-picked everything requested except #9865 (type guards), we talked with Jukka offline and agreed that it would be better to instead try to make the next release sooner.

@hauntsaninja
Copy link
Collaborator

Thanks!

re: AppVeyor build. Yes, all wheels (and sdist) are built by Github Actions. I think someone with access to the AppVeyor project needs to switch it off.

re: documentation PR #9923. I just merged it, so should be ready to cherry pick :-)
(IIUC ReadTheDocs are built on master, but shows up on https://mypy.readthedocs.io/en/latest/ whereas links and Google look at https://mypy.readthedocs.io/en/stable/)

@ilevkivskyi
Copy link
Member Author

It looks like we are moving quite smoothly and ahead of schedule. So unless there are objections, I am going to publish the release on PyPI tomorrow.

@ilevkivskyi
Copy link
Member Author

Released mypy 0.800 on PyPI, also here is the blog post http://mypy-lang.blogspot.com/2021/01/mypy-0800-released.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants