Switch Legacy to the Warehouse Service #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewdurbin
reviewed
Apr 30, 2018
| @@ -308,6 +326,12 @@ sub vcl_error { | |||
| set obj.http.Content-Type = "text/html; charset=UTF-8"; | |||
| synthetic {"<html><head><title>301 Moved Permanently</title></head><body><center><h1>301 Moved Permanently</h1></center></body></html>"}; | |||
| return(deliver); | |||
| } else if (obj.status == 751) { | |||
| set obj.status = 308; | |||
There was a problem hiding this comment.
are we doing 308s on the current service?
There was a problem hiding this comment.
❯ curl -XPOST https://pypi.python.org/ -i
HTTP/2 308
server: Varnish
retry-after: 0
location: https://pypi.org/
content-type: text/html; charset=UTF-8
accept-ranges: bytes
date: Mon, 30 Apr 2018 22:58:42 GMT
via: 1.1 varnish
x-served-by: cache-ewr18139-EWR
x-cache: HIT
x-cache-hits: 0
x-frame-options: deny
x-xss-protection: 1; mode=block
x-content-type-options: nosniff
x-permitted-cross-domain-policies: none
content-length: 124
<html><head><title>308 Permanent Redirect</title></head><body><center><h1>308 Permanent Redirect</h1></center></body></html>
ewdurbin
approved these changes
Apr 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.