Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language switcher disappears below 1024px #73

Closed
willingc opened this issue May 9, 2021 · 2 comments
Closed

Language switcher disappears below 1024px #73

willingc opened this issue May 9, 2021 · 2 comments
Labels

Comments

@willingc
Copy link
Contributor

willingc commented May 9, 2021

Thanks to @JulienPalard for deploying the new theme release: https://docs.python.org/3.11/

Below 1024px, the language switcher/selector disappears.

cc/ @obulat Thought you would enjoy seeing the theme deployed. It's a great improvement.

@willingc willingc added the bug label May 9, 2021
@obulat
Copy link
Contributor

obulat commented May 9, 2021

Thank you for deploying the theme on 3.11! I am really happy to see it 🎉

The language switcher on mobile screen is inside the menu:

Screen Shot 2021-05-09 at 8 32 21 AM

This way, the top bar is not too crowded, and users have enough space to use the search bar.

We could also put the language switcher to the bottom, but some pages are quite long, and it would be difficult to get to.

I've also created a PR with some fixes: #74

@hugovk
Copy link
Member

hugovk commented Feb 25, 2023

This is fixed now, thanks!

@hugovk hugovk closed this as completed Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants