Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subprocess.check_call should accept all POpen arguments #12084

Closed
danyeaw opened this issue Jun 2, 2024 · 1 comment · Fixed by #12086
Closed

subprocess.check_call should accept all POpen arguments #12084

danyeaw opened this issue Jun 2, 2024 · 1 comment · Fixed by #12086

Comments

@danyeaw
Copy link

danyeaw commented Jun 2, 2024

The following code is giving an unexpected argument error for the encoding argument:

subprocess.check_call(
        git_command + list(args),
        stderr=subprocess.DEVNULL,
        stdout=subprocess.DEVNULL,
        env=env,
        text=True,
        encoding="utf-8",
)

With error: Unexpected keyword argument "encoding" for "check_call" [call-arg].

However, the subprocess docs says that its signature is the same as the POpen constructor, which does accept encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant